* [-next PATCH] spi: omap-uwire: add missing iounmap
@ 2014-03-27 16:07 Nishanth Menon
2014-03-27 16:54 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Nishanth Menon @ 2014-03-27 16:07 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-spi, linux-kernel, Nishanth Menon
This fixes the following coccicheck warning:
linux-2.6/drivers/spi/spi-omap-uwire.c:485:2-8: ERROR: missing iounmap; ioremap on line 471 and execution via conditional on line 481
Signed-off-by: Nishanth Menon <nm@ti.com>
---
based on: next-20140326 tag
drivers/spi/spi-omap-uwire.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-omap-uwire.c b/drivers/spi/spi-omap-uwire.c
index 95cc694..e47c9c6 100644
--- a/drivers/spi/spi-omap-uwire.c
+++ b/drivers/spi/spi-omap-uwire.c
@@ -482,6 +482,7 @@ static int uwire_probe(struct platform_device *pdev)
status = PTR_ERR(uwire->ck);
dev_dbg(&pdev->dev, "no functional clock?\n");
spi_master_put(master);
+ iounmap(uwire_base);
return status;
}
clk_enable(uwire->ck);
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [-next PATCH] spi: omap-uwire: add missing iounmap
2014-03-27 16:07 [-next PATCH] spi: omap-uwire: add missing iounmap Nishanth Menon
@ 2014-03-27 16:54 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-03-27 16:54 UTC (permalink / raw)
To: Nishanth Menon; +Cc: linux-spi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 265 bytes --]
On Thu, Mar 27, 2014 at 11:07:59AM -0500, Nishanth Menon wrote:
> This fixes the following coccicheck warning:
> linux-2.6/drivers/spi/spi-omap-uwire.c:485:2-8: ERROR: missing iounmap; ioremap on line 471 and execution via conditional on line 481
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-27 16:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-27 16:07 [-next PATCH] spi: omap-uwire: add missing iounmap Nishanth Menon
2014-03-27 16:54 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®