* [PATCH] regmap: adds missing braces in regmap_init()
@ 2014-04-01 10:46 Daeseok Youn
2014-04-01 11:09 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Daeseok Youn @ 2014-04-01 10:46 UTC (permalink / raw)
To: broonie; +Cc: gregkh, linux-kernel
It need to add curly braces because the inner for "if" has
two statements.
coccicheck says:
drivers/base/regmap/regmap.c:765:2-44:
code aligned with following code on line 766
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
drivers/base/regmap/regmap.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index d0a0724..63e30ef 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -761,10 +761,11 @@ skip_format_initialization:
if (ret != 0)
goto err_range;
- if (dev)
+ if (dev) {
ret = regmap_attach_dev(dev, map, config);
if (ret != 0)
goto err_regcache;
+ }
return map;
--
1.7.4.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] regmap: adds missing braces in regmap_init()
2014-04-01 10:46 [PATCH] regmap: adds missing braces in regmap_init() Daeseok Youn
@ 2014-04-01 11:09 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-04-01 11:09 UTC (permalink / raw)
To: Daeseok Youn; +Cc: gregkh, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
On Tue, Apr 01, 2014 at 07:46:43PM +0900, Daeseok Youn wrote:
>
> It need to add curly braces because the inner for "if" has
> two statements.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-01 11:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-01 10:46 [PATCH] regmap: adds missing braces in regmap_init() Daeseok Youn
2014-04-01 11:09 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®