From: Francois Romieu <romieu@fr.zoreil.com>
To: Struan Bartlett <struan.bartlett@gmail.com>
Cc: Matt Mackall <mpm@selenic.com>,
linux-kernel@vger.kernel.org,
Andreas Schwab <schwab@linux-m68k.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Nikolay Aleksandrov <nikolay@redhat.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Pirko <jiri@resnulli.us>, Joe Perches <joe@perches.com>,
Dan Aloni <alonid@postram.com>
Subject: Re: [PATCH v3] netconsole: Add tty driver
Date: Thu, 3 Apr 2014 01:12:35 +0200 [thread overview]
Message-ID: <20140402231235.GA5013@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20140402185904.GD11734@NewsNow.co.uk>
Struan Bartlett <struan.bartlett@gmail.com> :
[...]
> --- a/drivers/net/netconsole.c 2014-03-31 04:40:15.000000000 +0100
> +++ b/drivers/net/netconsole.c 2014-04-01 11:58:50.000000000 +0100
> @@ -15,6 +15,7 @@
> * generic card hooks
> * works non-modular
> * 2003-09-07 rewritten with netpoll api
> + * 2014-03-31 tty driver by Struan Bartlett
Useless.
[...]
> +static int netconsole_tty_put_char(struct tty_struct *tty, unsigned char ch)
> +{
> + char temp[2] = { ch, 0 };
> + _write_msg(temp, 1);
Please add an empty line after declaration.
[...]
> @@ -802,11 +857,39 @@ static int __init init_netconsole(void)
> if (err)
> goto undonotifier;
>
> + netconsole_tty_driver = alloc_tty_driver(1);
alloc_tty_driver is said deprecated in include/linux/tty_driver.h
http://marc.info/?l=linux-netdev&m=139629339513575 may delay things a bit.
If so please be patient.
--
Ueimor
next prev parent reply other threads:[~2014-04-02 23:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 18:59 Struan Bartlett
2014-04-02 23:12 ` Francois Romieu [this message]
2014-04-06 17:21 ` One Thousand Gnomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140402231235.GA5013@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=alonid@postram.com \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@resnulli.us \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=schwab@linux-m68k.org \
--cc=struan.bartlett@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®