From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mike Sampson <mike@sambodata.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Kees Cook <keescook@chromium.org>, Peng Tao <bergwolf@gmail.com>,
linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] v3.14-7247-gcd6362b drivers/staging/lustre/lustre/libcfs/workitem.c Fix sparse warning.
Date: Thu, 3 Apr 2014 13:29:31 +0300 [thread overview]
Message-ID: <20140403102931.GK6991@mwanda> (raw)
In-Reply-To: <533d3246.82e6440a.77e1.ffffa143@mx.google.com>
On Thu, Apr 03, 2014 at 08:43:28PM +1100, Mike Sampson wrote:
> Signed-off-by: Mike Sampson <mike@sambodata.com>
>
> This fixes a sparse warning:
> warning: symbol 'cfs_wi_data' was not declared. Should it be static?
>
Patch is ok. Signed off should go at the end instead of at the start of
the commit message. The subject should be:
[PATCH] Staging: lustre: mark a variable static in workitem.c
Espcially notice how I removed the "v3.14-7247-gcd6362b" and chose a
better prefix. Btw, for these kinds of changes, then you should be
working against -next.
regards,
dan carpenter
prev parent reply other threads:[~2014-04-03 10:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 9:43 Mike Sampson
2014-04-03 10:29 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403102931.GK6991@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@sambodata.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome