* [PATCH] v3.14-7247-gcd6362b drivers/staging/lustre/lustre/libcfs/workitem.c Fix sparse warning.
@ 2014-04-03 9:43 Mike Sampson
2014-04-03 10:29 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Mike Sampson @ 2014-04-03 9:43 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Peng Tao, Masanari Iida, Andreas Dilger, Kees Cook, devel,
linux-kernel, trivial
Signed-off-by: Mike Sampson <mike@sambodata.com>
This fixes a sparse warning:
warning: symbol 'cfs_wi_data' was not declared. Should it be static?
---
drivers/staging/lustre/lustre/libcfs/workitem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/workitem.c b/drivers/staging/lustre/lustre/libcfs/workitem.c
index ba16fd5..0a03bf7 100644
--- a/drivers/staging/lustre/lustre/libcfs/workitem.c
+++ b/drivers/staging/lustre/lustre/libcfs/workitem.c
@@ -75,7 +75,7 @@ typedef struct cfs_wi_sched {
char ws_name[CFS_WS_NAME_LEN];
} cfs_wi_sched_t;
-struct cfs_workitem_data {
+static struct cfs_workitem_data {
/** serialize */
spinlock_t wi_glock;
/** list of all schedulers */
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] v3.14-7247-gcd6362b drivers/staging/lustre/lustre/libcfs/workitem.c Fix sparse warning.
2014-04-03 9:43 [PATCH] v3.14-7247-gcd6362b drivers/staging/lustre/lustre/libcfs/workitem.c Fix sparse warning Mike Sampson
@ 2014-04-03 10:29 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-04-03 10:29 UTC (permalink / raw)
To: Mike Sampson
Cc: Greg Kroah-Hartman, devel, Andreas Dilger, Kees Cook, Peng Tao,
linux-kernel, trivial
On Thu, Apr 03, 2014 at 08:43:28PM +1100, Mike Sampson wrote:
> Signed-off-by: Mike Sampson <mike@sambodata.com>
>
> This fixes a sparse warning:
> warning: symbol 'cfs_wi_data' was not declared. Should it be static?
>
Patch is ok. Signed off should go at the end instead of at the start of
the commit message. The subject should be:
[PATCH] Staging: lustre: mark a variable static in workitem.c
Espcially notice how I removed the "v3.14-7247-gcd6362b" and chose a
better prefix. Btw, for these kinds of changes, then you should be
working against -next.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-03 10:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-03 9:43 [PATCH] v3.14-7247-gcd6362b drivers/staging/lustre/lustre/libcfs/workitem.c Fix sparse warning Mike Sampson
2014-04-03 10:29 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome