mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Dave Reisner <d@falconindy.com>
Cc: linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	thomas@archlinux.org, P@draigbrady.com,
	alexandre.f.demers@gmail.com
Subject: Re: Initramfs FSID altered in 3.14
Date: Thu, 3 Apr 2014 15:13:07 -0400	[thread overview]
Message-ID: <20140403191307.GA2472@mtj.dyndns.org> (raw)
In-Reply-To: <20140403175744.GE585@rampage>

Hello, Dave.

On Thu, Apr 03, 2014 at 01:57:44PM -0400, Dave Reisner wrote:
> With Linux 3.14, you might notice in /proc/self/mountinfo that your
> root's parent FSID is now 0, instead of the 1 that it's been for the
> last N years. Tejun wrote the change (9e30cc9595303b27b48) that caused
> this, but the change comes in a rather innocuous way. Instead of an
> internal kernel mount of sysfs being assigned 0, it's now the initramfs.
> 
> So far, this has already caused switch_root and findmnt (from
> util-linux) to break, cp (from coreutils) to break when using the -x
> flag in early userspace, and it's also been pointed out that systemd's
> readahead code makes assumptions about a device number of 0.
> 
> Are we now supposed to go and change all the assumptions in userspace
> about 0 being special? I'm conflicted. The kernel isn't supposed to
> break userspace, but it seems to me that FSIDs were never something to
> rely on -- similar to the block device numbering scheme.

I think this is the same problem Alexandre Demers reported.  Arch was
failing to boot with the commit.  There's already a patch pending to
reinstate the internal mount but I think what Thomas is proposing -
just starting allocating FSID from 1 is a better solution.  Alexandre,
can you please test Thomas' patch?

Thanks.

-- 
tejun

      parent reply	other threads:[~2014-04-03 19:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03 17:57 Dave Reisner
2014-04-03 18:13 ` Thomas Bächler
2014-04-03 19:16   ` Tejun Heo
2014-04-03 19:20     ` Theodore Ts'o
2014-04-03 22:02       ` Alexandre Demers
2014-04-03 19:49     ` [PATCH] fs: Don't return 0 from get_anon_bdev Thomas Bächler
2014-04-03 19:51       ` Tejun Heo
2014-04-03 19:55         ` [PATCHv2] " Thomas Bächler
2014-04-03 20:32           ` Greg KH
2014-04-03 20:21       ` [PATCH] " H. Peter Anvin
2014-04-03 23:41       ` Alexandre Demers
2014-04-03 18:57 ` Initramfs FSID altered in 3.14 Pádraig Brady
2014-04-03 19:13 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140403191307.GA2472@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=P@draigbrady.com \
    --cc=alexandre.f.demers@gmail.com \
    --cc=d@falconindy.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas@archlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome