From: Tejun Heo <tj@kernel.org>
To: "Thomas Bächler" <thomas@archlinux.org>
Cc: Dave Reisner <d@falconindy.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
thomas@archlinux.org, P@draigbrady.com,
alexandre.f.demers@gmail.com
Subject: Re: Initramfs FSID altered in 3.14
Date: Thu, 3 Apr 2014 15:16:17 -0400 [thread overview]
Message-ID: <20140403191617.GB2472@mtj.dyndns.org> (raw)
In-Reply-To: <533DA4DE.40408@archlinux.org>
Hello,
On Thu, Apr 03, 2014 at 08:13:50PM +0200, Thomas Bächler wrote:
> Most of these bugs were not caused by rootfs' FSID being different from
> 1, but rather because there was a file system with FSID 0.
>
> Only util-linux/switch_root assumed that rootfs always had exactly FSID
> 1 - which is IMO a wrong assumption.
>
> However, tt seems that people have been assuming that st_dev > 0 for a
> while. If we want to revert this in the kernel, this patch (untested)
> should be sufficient:
>
> diff --git a/fs/super.c b/fs/super.c
> index 80d5cf2..d9fddde 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -802,7 +802,7 @@ void emergency_remount(void)
> static DEFINE_IDA(unnamed_dev_ida);
> static DEFINE_SPINLOCK(unnamed_dev_lock);/* protects the above */
> -static int unnamed_dev_start = 0; /* don't bother trying below it */
> +static int unnamed_dev_start = 1; /* don't bother trying below it */
> int get_anon_bdev(dev_t *p)
> {
Alexandre, this is the one line change that should fix it. Can you
please test it?
Thomas, can you please write proper patch description with reference
to the following thread and stable # 3.14 tag?
http://lkml.kernel.org/g/CAPEhTTFP3N-ReasmgL5n82mve8p8M3crqmaMvzV+F2p5JCSRbQ@mail.gmail.com
Thanks.
--
tejun
next prev parent reply other threads:[~2014-04-03 19:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 17:57 Dave Reisner
2014-04-03 18:13 ` Thomas Bächler
2014-04-03 19:16 ` Tejun Heo [this message]
2014-04-03 19:20 ` Theodore Ts'o
2014-04-03 22:02 ` Alexandre Demers
2014-04-03 19:49 ` [PATCH] fs: Don't return 0 from get_anon_bdev Thomas Bächler
2014-04-03 19:51 ` Tejun Heo
2014-04-03 19:55 ` [PATCHv2] " Thomas Bächler
2014-04-03 20:32 ` Greg KH
2014-04-03 20:21 ` [PATCH] " H. Peter Anvin
2014-04-03 23:41 ` Alexandre Demers
2014-04-03 18:57 ` Initramfs FSID altered in 3.14 Pádraig Brady
2014-04-03 19:13 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403191617.GB2472@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=P@draigbrady.com \
--cc=alexandre.f.demers@gmail.com \
--cc=d@falconindy.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@archlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®