* [PATCH] spi: qup: Depend on ARCH_QCOM
@ 2014-04-06 11:45 Paul Bolle
2014-04-07 13:08 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Paul Bolle @ 2014-04-06 11:45 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-spi, linux-kernel
Commit 8fc1b0f87d9f ("ARM: qcom: Split Qualcomm support into legacy and
multiplatform") removed Kconfig symbol ARCH_MSM_DT. But that commit
left one (optional) dependency on ARCH_MSM_DT untouched.
Three Kconfig symbols used to depend on ARCH_MSM_DT: ARCH_MSM8X60,
ARCH_MSM8960, and ARCH_MSM8974. These three symbols now depend on
ARCH_QCOM. So it appears this driver needs to depend on ARCH_QCOM too.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Untested!
Note that this is basically guesswork: looking at commit 8fc1b0f87d9f it
appears to make sense to pick ARCH_QCOM here.
drivers/spi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index efe1960af2b3..60f2b41c7310 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -383,7 +383,7 @@ config SPI_RSPI
config SPI_QUP
tristate "Qualcomm SPI controller with QUP interface"
- depends on ARCH_MSM_DT || (ARM && COMPILE_TEST)
+ depends on ARCH_QCOM || (ARM && COMPILE_TEST)
help
Qualcomm Universal Peripheral (QUP) core is an AHB slave that
provides a common data path (an output FIFO and an input FIFO)
--
1.9.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] spi: qup: Depend on ARCH_QCOM
2014-04-06 11:45 [PATCH] spi: qup: Depend on ARCH_QCOM Paul Bolle
@ 2014-04-07 13:08 ` Mark Brown
2014-04-07 14:15 ` [PATCH] [RESEND] " Paul Bolle
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2014-04-07 13:08 UTC (permalink / raw)
To: Paul Bolle; +Cc: linux-spi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
On Sun, Apr 06, 2014 at 01:45:33PM +0200, Paul Bolle wrote:
> Commit 8fc1b0f87d9f ("ARM: qcom: Split Qualcomm support into legacy and
> multiplatform") removed Kconfig symbol ARCH_MSM_DT. But that commit
> left one (optional) dependency on ARCH_MSM_DT untouched.
>
> Three Kconfig symbols used to depend on ARCH_MSM_DT: ARCH_MSM8X60,
> ARCH_MSM8960, and ARCH_MSM8974. These three symbols now depend on
> ARCH_QCOM. So it appears this driver needs to depend on ARCH_QCOM too.
You probably want to CC some of the Qualcomm people (or whoever made the
above change) who know what's going on with these symbols.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] [RESEND] spi: qup: Depend on ARCH_QCOM
2014-04-07 13:08 ` Mark Brown
@ 2014-04-07 14:15 ` Paul Bolle
2014-04-07 22:22 ` Stephen Boyd
2014-04-08 11:09 ` Mark Brown
0 siblings, 2 replies; 5+ messages in thread
From: Paul Bolle @ 2014-04-07 14:15 UTC (permalink / raw)
To: Mark Brown, Kumar Gala, David Brown
Cc: linux-spi, linux-arm-msm, linux-kernel
Commit 8fc1b0f87d9f ("ARM: qcom: Split Qualcomm support into legacy and
multiplatform") removed Kconfig symbol ARCH_MSM_DT. But that commit
left one (optional) dependency on ARCH_MSM_DT untouched.
Three Kconfig symbols used to depend on ARCH_MSM_DT: ARCH_MSM8X60,
ARCH_MSM8960, and ARCH_MSM8974. These three symbols now depend on
ARCH_QCOM. So it appears this driver needs to depend on ARCH_QCOM too.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Resending, because Mark suggested to include the Qualcomm people (who
know what's going on with these symbols).
Still untested!
Note that this is basically guesswork: looking at commit 8fc1b0f87d9f it
appears to make sense to pick ARCH_QCOM here.
drivers/spi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index efe1960af2b3..60f2b41c7310 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -383,7 +383,7 @@ config SPI_RSPI
config SPI_QUP
tristate "Qualcomm SPI controller with QUP interface"
- depends on ARCH_MSM_DT || (ARM && COMPILE_TEST)
+ depends on ARCH_QCOM || (ARM && COMPILE_TEST)
help
Qualcomm Universal Peripheral (QUP) core is an AHB slave that
provides a common data path (an output FIFO and an input FIFO)
--
1.9.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] [RESEND] spi: qup: Depend on ARCH_QCOM
2014-04-07 14:15 ` [PATCH] [RESEND] " Paul Bolle
@ 2014-04-07 22:22 ` Stephen Boyd
2014-04-08 11:09 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2014-04-07 22:22 UTC (permalink / raw)
To: Paul Bolle
Cc: Mark Brown, Kumar Gala, David Brown, linux-spi, linux-arm-msm,
linux-kernel
On 04/07, Paul Bolle wrote:
> Commit 8fc1b0f87d9f ("ARM: qcom: Split Qualcomm support into legacy and
> multiplatform") removed Kconfig symbol ARCH_MSM_DT. But that commit
> left one (optional) dependency on ARCH_MSM_DT untouched.
>
> Three Kconfig symbols used to depend on ARCH_MSM_DT: ARCH_MSM8X60,
> ARCH_MSM8960, and ARCH_MSM8974. These three symbols now depend on
> ARCH_QCOM. So it appears this driver needs to depend on ARCH_QCOM too.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
> Resending, because Mark suggested to include the Qualcomm people (who
> know what's going on with these symbols).
>
> Still untested!
>
> Note that this is basically guesswork: looking at commit 8fc1b0f87d9f it
> appears to make sense to pick ARCH_QCOM here.
That's correct.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] [RESEND] spi: qup: Depend on ARCH_QCOM
2014-04-07 14:15 ` [PATCH] [RESEND] " Paul Bolle
2014-04-07 22:22 ` Stephen Boyd
@ 2014-04-08 11:09 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2014-04-08 11:09 UTC (permalink / raw)
To: Paul Bolle
Cc: Kumar Gala, David Brown, linux-spi, linux-arm-msm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 281 bytes --]
On Mon, Apr 07, 2014 at 04:15:45PM +0200, Paul Bolle wrote:
> Commit 8fc1b0f87d9f ("ARM: qcom: Split Qualcomm support into legacy and
> multiplatform") removed Kconfig symbol ARCH_MSM_DT. But that commit
> left one (optional) dependency on ARCH_MSM_DT untouched.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-04-08 11:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-06 11:45 [PATCH] spi: qup: Depend on ARCH_QCOM Paul Bolle
2014-04-07 13:08 ` Mark Brown
2014-04-07 14:15 ` [PATCH] [RESEND] " Paul Bolle
2014-04-07 22:22 ` Stephen Boyd
2014-04-08 11:09 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome