mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] bcm: Fixing a few checkpatch issues in InterfaceMisc.h
@ 2014-04-13 18:56 JulianGindi
  2014-04-13 19:31 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: JulianGindi @ 2014-04-13 18:56 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel

Just cleaned up a few issues presented by checkpatch in InterfaceMisc.h. I converted some spaces to tabs, and removed unnecessary whitespace. The kernel version I am using linux-next-20140411.

Signed-off-by: JulianGindi <juliangindi@gmail.com>
---
 drivers/staging/bcm/InterfaceMisc.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/bcm/InterfaceMisc.h b/drivers/staging/bcm/InterfaceMisc.h
index bce6869..efb6860 100644
--- a/drivers/staging/bcm/InterfaceMisc.h
+++ b/drivers/staging/bcm/InterfaceMisc.h
@@ -14,13 +14,13 @@ InterfaceWRM(struct bcm_interface_adapter *psIntfAdapter,
 			INT len);
 
 
-int InterfaceFileDownload( PVOID psIntfAdapter,
-                        struct file *flp,
-                        unsigned int on_chip_loc);
+int InterfaceFileDownload(PVOID psIntfAdapter,
+			struct file *flp,
+			unsigned int on_chip_loc);
 
-int InterfaceFileReadbackFromChip( PVOID psIntfAdapter,
-                        struct file *flp,
-                        unsigned int on_chip_loc);
+int InterfaceFileReadbackFromChip(PVOID psIntfAdapter,
+			struct file *flp,
+			unsigned int on_chip_loc);
 
 
 int BcmRDM(PVOID arg,
-- 
1.9.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] bcm: Fixing a few checkpatch issues in InterfaceMisc.h
  2014-04-13 18:56 [PATCH] bcm: Fixing a few checkpatch issues in InterfaceMisc.h JulianGindi
@ 2014-04-13 19:31 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-04-13 19:31 UTC (permalink / raw)
  To: JulianGindi; +Cc: devel, linux-kernel

On Sun, Apr 13, 2014 at 02:56:57PM -0400, JulianGindi wrote:
> Just cleaned up a few issues presented by checkpatch in InterfaceMisc.h. I converted some spaces to tabs, and removed unnecessary whitespace. The kernel version I am using linux-next-20140411.

That's a very long line, please wrap them properly.

> Signed-off-by: JulianGindi <juliangindi@gmail.com>

That might be your real name, but odds are, there needs to be a space in
there somewhere, right?

Please read Documentation/SubmittingPatches about what that line means,
and why we need a real name there.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-04-13 19:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-13 18:56 [PATCH] bcm: Fixing a few checkpatch issues in InterfaceMisc.h JulianGindi
2014-04-13 19:31 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®