From: Jean Delvare <jdelvare@suse.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/5] driver core: dev_set_drvdata can no longer fail
Date: Mon, 14 Apr 2014 12:55:38 +0200 [thread overview]
Message-ID: <20140414125538.21ec0d7e@endymion.delvare> (raw)
In-Reply-To: <20140414124802.2859439e@endymion.delvare>
So there is no point in checking its return value, which will soon
disappear.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/iommu/exynos-iommu.c | 7 +------
drivers/vfio/vfio.c | 8 +-------
2 files changed, 2 insertions(+), 13 deletions(-)
--- linux-3.15-rc0.orig/drivers/iommu/exynos-iommu.c 2014-04-08 16:23:59.159885163 +0200
+++ linux-3.15-rc0/drivers/iommu/exynos-iommu.c 2014-04-08 16:25:47.491199974 +0200
@@ -542,12 +542,7 @@ static int exynos_sysmmu_probe(struct pl
goto err_alloc;
}
- ret = dev_set_drvdata(dev, data);
- if (ret) {
- dev_dbg(dev, "Unabled to initialize driver data\n");
- goto err_init;
- }
-
+ dev_set_drvdata(dev, data);
data->nsfrs = pdev->num_resources / 2;
data->sfrbases = kmalloc(sizeof(*data->sfrbases) * data->nsfrs,
GFP_KERNEL);
--- linux-3.15-rc0.orig/drivers/vfio/vfio.c 2014-04-08 16:23:59.159885163 +0200
+++ linux-3.15-rc0/drivers/vfio/vfio.c 2014-04-08 16:28:14.690345108 +0200
@@ -349,7 +349,6 @@ struct vfio_device *vfio_group_create_de
void *device_data)
{
struct vfio_device *device;
- int ret;
device = kzalloc(sizeof(*device), GFP_KERNEL);
if (!device)
@@ -360,12 +359,7 @@ struct vfio_device *vfio_group_create_de
device->group = group;
device->ops = ops;
device->device_data = device_data;
-
- ret = dev_set_drvdata(dev, device);
- if (ret) {
- kfree(device);
- return ERR_PTR(ret);
- }
+ dev_set_drvdata(dev, device);
/* No need to get group_lock, caller has group reference */
vfio_group_get(group);
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2014-04-14 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 10:48 [PATCH 0/5] driver core: Clean up dev_get/set_drvdata Jean Delvare
2014-04-14 10:54 ` [PATCH 1/5] driver core: Move driver_data back to struct device Jean Delvare
2014-04-14 10:55 ` Jean Delvare [this message]
2014-04-14 10:56 ` [PATCH 3/5] driver core: dev_set_drvdata returns void Jean Delvare
2014-04-14 10:57 ` [PATCH 4/5] driver core: dev_get_drvdata: Don't check for NULL dev Jean Delvare
2014-04-14 10:58 ` [PATCH 5/5] driver core: Inline dev_set/get_drvdata Jean Delvare
2014-04-14 11:50 ` [PATCH 0/5] driver core: Clean up dev_get/set_drvdata Greg KH
2014-05-27 20:50 ` Greg KH
2014-05-27 20:57 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414125538.21ec0d7e@endymion.delvare \
--to=jdelvare@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®