From: Jean Delvare <jdelvare@suse.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/5] driver core: dev_set_drvdata returns void
Date: Mon, 14 Apr 2014 12:56:34 +0200 [thread overview]
Message-ID: <20140414125634.546c97ef@endymion.delvare> (raw)
In-Reply-To: <20140414124802.2859439e@endymion.delvare>
dev_set_drvdata can no longer fail, so it could return void.
All callers have hopefully been updated to no longer check for the
return value.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/base/dd.c | 3 +--
include/linux/device.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
--- linux-3.15-rc1.orig/drivers/base/dd.c 2014-04-14 12:52:52.957743343 +0200
+++ linux-3.15-rc1/drivers/base/dd.c 2014-04-14 12:54:21.520907390 +0200
@@ -583,9 +583,8 @@ void *dev_get_drvdata(const struct devic
}
EXPORT_SYMBOL(dev_get_drvdata);
-int dev_set_drvdata(struct device *dev, void *data)
+void dev_set_drvdata(struct device *dev, void *data)
{
dev->driver_data = data;
- return 0;
}
EXPORT_SYMBOL(dev_set_drvdata);
--- linux-3.15-rc1.orig/include/linux/device.h 2014-04-14 12:53:10.284166917 +0200
+++ linux-3.15-rc1/include/linux/device.h 2014-04-14 12:54:18.863842502 +0200
@@ -917,7 +917,7 @@ extern const char *device_get_devnode(st
umode_t *mode, kuid_t *uid, kgid_t *gid,
const char **tmp);
extern void *dev_get_drvdata(const struct device *dev);
-extern int dev_set_drvdata(struct device *dev, void *data);
+extern void dev_set_drvdata(struct device *dev, void *data);
static inline bool device_supports_offline(struct device *dev)
{
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2014-04-14 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 10:48 [PATCH 0/5] driver core: Clean up dev_get/set_drvdata Jean Delvare
2014-04-14 10:54 ` [PATCH 1/5] driver core: Move driver_data back to struct device Jean Delvare
2014-04-14 10:55 ` [PATCH 2/5] driver core: dev_set_drvdata can no longer fail Jean Delvare
2014-04-14 10:56 ` Jean Delvare [this message]
2014-04-14 10:57 ` [PATCH 4/5] driver core: dev_get_drvdata: Don't check for NULL dev Jean Delvare
2014-04-14 10:58 ` [PATCH 5/5] driver core: Inline dev_set/get_drvdata Jean Delvare
2014-04-14 11:50 ` [PATCH 0/5] driver core: Clean up dev_get/set_drvdata Greg KH
2014-05-27 20:50 ` Greg KH
2014-05-27 20:57 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414125634.546c97ef@endymion.delvare \
--to=jdelvare@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®