mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	guohanjun@huawei.com, Kefeng Wang <kefeng.wang@linaro.org>,
	Haojian Zhuang <haojian.zhuang@linaro.org>
Subject: Re: [PATCH V2 1/2] ata: ahci: append new hflag AHCI_HFLAG_NO_FBS
Date: Wed, 16 Apr 2014 16:49:55 -0400	[thread overview]
Message-ID: <20140416204955.GC26632@htj.dyndns.org> (raw)
In-Reply-To: <1397107468-640-2-git-send-email-wangkefeng.wang@huawei.com>

On Thu, Apr 10, 2014 at 01:24:27PM +0800, Kefeng Wang wrote:
> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
> index 6bd4f66..573edb3 100644
> --- a/drivers/ata/libahci.c
> +++ b/drivers/ata/libahci.c
> @@ -452,6 +452,11 @@ void ahci_save_initial_config(struct device *dev,
>  		cap &= ~HOST_CAP_SNTF;
>  	}
>  
> +	if ((cap & HOST_CAP_FBS) && (hpriv->flags & AHCI_HFLAG_NO_FBS)) {
> +		dev_info(dev, "controller can't do FBS, turning off CAP_FBS\n");
> +		cap &= ~HOST_CAP_FBS;
> +	}

Can you please put this chunk after YES_FBS?

>  	if (!(cap & HOST_CAP_FBS) && (hpriv->flags & AHCI_HFLAG_YES_FBS)) {
>  		dev_info(dev, "controller can do FBS, turning on CAP_FBS\n");
>  		cap |= HOST_CAP_FBS;

Thanks.

-- 
tejun

  reply	other threads:[~2014-04-16 20:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10  5:24 [PATCH V2 0/2] ahci: support for hisilicon sata Kefeng Wang
2014-04-10  5:24 ` [PATCH V2 1/2] ata: ahci: append new hflag AHCI_HFLAG_NO_FBS Kefeng Wang
2014-04-16 20:49   ` Tejun Heo [this message]
2014-04-10  5:24 ` [PATCH V2 2/2] ahci: add support for Hisilicon sata Kefeng Wang
2014-04-16 20:49   ` Tejun Heo
2014-04-17  7:48     ` Hans de Goede
2014-04-17 13:31       ` Tejun Heo
2014-04-18  1:07         ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140416204955.GC26632@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=guohanjun@huawei.com \
    --cc=haojian.zhuang@linaro.org \
    --cc=hdegoede@redhat.com \
    --cc=kefeng.wang@linaro.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®