mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Tim Kryger <tim.kryger@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: Allow set voltage on fixed regulators
Date: Fri, 18 Apr 2014 19:52:25 +0100	[thread overview]
Message-ID: <20140418185225.GA12304@sirena.org.uk> (raw)
In-Reply-To: <1397845810-17002-1-git-send-email-tim.kryger@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 718 bytes --]

On Fri, Apr 18, 2014 at 11:30:10AM -0700, Tim Kryger wrote:
> If a regulator consumer requests a voltage range that can be satisfied,
> the return value should indicate success even if that regulator has a
> fixed voltage.  Since there is already logic to check if the requested
> voltage range overlaps the allowed range, set REGULATOR_CHANGE_VOLTAGE
> for regulators with constraints that include a positive voltage.

This seems like the wrong place to fix this, it's nothing to do with DT
and we shouldn't require that nonsensical permissions are set.  Instead
we should fix this at the point where we're implementing the permission
check, have the failure case check the current voltage before returning
an error.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-04-18 18:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-18 18:30 Tim Kryger
2014-04-18 18:52 ` Mark Brown [this message]
2014-04-18 21:07   ` Tim Kryger
2014-04-18 21:29     ` Mark Brown
2014-04-22 18:38   ` Tim Kryger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140418185225.GA12304@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tim.kryger@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®