mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: davem@davemloft.net, lizefan@huawei.com, nhorman@tuxdriver.com,
	daniel.wagner@bmw-carit.de, jiri@resnulli.us,
	gaofeng@cn.fujitsu.com, stephen@networkplumber.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] netprio_cgroup: use accessor to get id from css
Date: Tue, 22 Apr 2014 16:33:48 -0400	[thread overview]
Message-ID: <20140422203348.GE2314@mtj.dyndns.org> (raw)
In-Reply-To: <0b10af801af45fdbf4835e8da54273e9752b239f.1398147734.git.nasa4836@gmail.com>

On Tue, Apr 22, 2014 at 02:31:01PM +0800, Jianyu Zhan wrote:
> This is a prepared patch for converting from per-cgroup id to
> per-subsystem id.
> 
> We should not access per-cgroup id directly, since this is
> implemetation detail.
> 
> Use the accessor css_from_id() instead.
> 
> This patch has no functional change.

netprio_cgroup is a cgroup identifying controller.  We *do* want to
use per-cgroup IDs for it.

Thanks.

-- 
tejun

  parent reply	other threads:[~2014-04-22 20:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22  6:30 [PATCH 0/4] cgroup: substitude per-cgroup id with per-subsys id Jianyu Zhan
2014-04-22  6:30 ` [PATCH 1/4] cgroup: introduce helper css_to_id() Jianyu Zhan
2014-04-22 20:31   ` Tejun Heo
2014-04-22  6:30 ` [PATCH 2/4] mm/memcontrol.c: use accessor to get id from css Jianyu Zhan
2014-04-22  7:03   ` Jianyu Zhan
2014-04-22  8:08   ` Jianyu Zhan
2014-04-22 10:01   ` Michal Hocko
     [not found]   ` <20140422124920.e22ed65d33d2b982ef467372@linux-foundation.org>
2014-04-23  6:41     ` Jianyu Zhan
2014-04-22  6:31 ` [PATCH 3/4] netprio_cgroup: " Jianyu Zhan
2014-04-22 11:27   ` Neil Horman
2014-04-22 20:33   ` Tejun Heo [this message]
2014-04-22  6:31 ` [PATCH 4/4] cgroup: convert from per-cgroup id to per-subsys id Jianyu Zhan
2014-04-22  8:03 ` Jianyu Zhan
2014-04-22 20:36   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140422203348.GE2314@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=daniel.wagner@bmw-carit.de \
    --cc=davem@davemloft.net \
    --cc=gaofeng@cn.fujitsu.com \
    --cc=jiri@resnulli.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=nasa4836@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®