mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: lizefan@huawei.com, containers@lists.linux-foundation.org,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] cgroup: convert from per-cgroup id to per-subsys id
Date: Tue, 22 Apr 2014 16:36:32 -0400	[thread overview]
Message-ID: <20140422203632.GF2314@mtj.dyndns.org> (raw)
In-Reply-To: <f478e92038bfbc1da2d03082641804e8acfdfad3.1398153537.git.nasa4836@gmail.com>

On Tue, Apr 22, 2014 at 04:03:31PM +0800, Jianyu Zhan wrote:
> Hi, all.
> 
> Sorry, previous patch has a minor fault, and cause a unitialized variable warning.
> I've fixed it up in this.
> 
> Renewed patch:
> ---
> 
> Currently, cgrp->id is only used to look up css's.  As cgroup and
> css's lifetimes is now decoupled, it should be made per-subsystem
> and moved to css->css_id so that lookups are successful until the
> target css is released.

So, css ID can't replace cgroup ID as whole.  It's just that there are
cases where we're currently using cgroup IDs where we should be using
css IDs.  Also, we need to update css creation error path RCU safe so
that idr lookup is always RCU safe.  I already had patches queued for
posting.  Will post them soon.

Thanks.

-- 
tejun

      reply	other threads:[~2014-04-22 20:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22  6:30 [PATCH 0/4] cgroup: substitude per-cgroup id with " Jianyu Zhan
2014-04-22  6:30 ` [PATCH 1/4] cgroup: introduce helper css_to_id() Jianyu Zhan
2014-04-22 20:31   ` Tejun Heo
2014-04-22  6:30 ` [PATCH 2/4] mm/memcontrol.c: use accessor to get id from css Jianyu Zhan
2014-04-22  7:03   ` Jianyu Zhan
2014-04-22  8:08   ` Jianyu Zhan
2014-04-22 10:01   ` Michal Hocko
     [not found]   ` <20140422124920.e22ed65d33d2b982ef467372@linux-foundation.org>
2014-04-23  6:41     ` Jianyu Zhan
2014-04-22  6:31 ` [PATCH 3/4] netprio_cgroup: " Jianyu Zhan
2014-04-22 11:27   ` Neil Horman
2014-04-22 20:33   ` Tejun Heo
2014-04-22  6:31 ` [PATCH 4/4] cgroup: convert from per-cgroup id to per-subsys id Jianyu Zhan
2014-04-22  8:03 ` Jianyu Zhan
2014-04-22 20:36   ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140422203632.GF2314@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=nasa4836@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®