From: Tejun Heo <tj@kernel.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, Li Zefan <lizefan@huawei.com>,
cgroups@vger.kernel.org
Subject: Re: [PATCH RFC] blkcg: prepare blkcg knobs for default hierarchy
Date: Wed, 23 Apr 2014 15:00:43 -0400 [thread overview]
Message-ID: <20140423190043.GB4163@mtj.dyndns.org> (raw)
In-Reply-To: <20140423185835.GD22755@redhat.com>
Hello,
On Wed, Apr 23, 2014 at 02:58:35PM -0400, Vivek Goyal wrote:
> Oh, sorry, I had misunderstood your question.
>
> - Number of IOs serviced will be different at throttling layer and
> CFQ layer as throttling accounts IO in terms of bios and CFQ
> accounts in terms of number of requests.
But shouldn't it be possible to determine that from merged count? Or
we can just expose both bio and request counts at block core layer.
The point is that there's nothing controller specific about these
stats.
> - CFQ might not be operational on a device while throttling might be
> on and one needs bytes stats.
Yeah, so expose both from blkcg core as blkio.* stats.
> - In a custom kernel throttling might not be on and CFQ is on and
> one needs the stats.
Ditto.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-04-23 19:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 1:32 Tejun Heo
2014-04-14 18:08 ` Vivek Goyal
2014-04-14 19:32 ` Tejun Heo
2014-04-15 13:53 ` Vivek Goyal
2014-04-15 14:06 ` Tejun Heo
2014-04-15 14:18 ` Vivek Goyal
2014-04-23 17:01 ` Tejun Heo
2014-04-23 17:17 ` Vivek Goyal
2014-04-23 18:52 ` Tejun Heo
2014-04-23 18:58 ` Vivek Goyal
2014-04-23 19:00 ` Tejun Heo [this message]
2014-04-23 19:21 ` Vivek Goyal
2014-04-23 19:27 ` Tejun Heo
2014-05-23 17:39 ` Tejun Heo
2014-05-27 12:49 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423190043.GB4163@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®