mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] tty: n_hdlc: Drop redundant error message
@ 2014-04-25  9:02 Jean Delvare
  0 siblings, 0 replies; only message in thread
From: Jean Delvare @ 2014-04-25  9:02 UTC (permalink / raw)
  To: LKML; +Cc: Greg Kroah-Hartman, Jiri Slaby

On initialization failure, an error message is already printed with
level KERN_ERR, no need to print another one with level KERN_INFO.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>
---
 drivers/tty/n_hdlc.c |    4 ----
 1 file changed, 4 deletions(-)

--- linux-3.15-rc2.orig/drivers/tty/n_hdlc.c	2014-03-31 05:40:15.000000000 +0200
+++ linux-3.15-rc2/drivers/tty/n_hdlc.c	2014-04-25 10:41:32.532755760 +0200
@@ -952,8 +952,6 @@ static char hdlc_register_ok[] __initdat
 	KERN_INFO "N_HDLC line discipline registered.\n";
 static char hdlc_register_fail[] __initdata =
 	KERN_ERR "error registering line discipline: %d\n";
-static char hdlc_init_fail[] __initdata =
-	KERN_INFO "N_HDLC: init failure %d\n";
 
 static int __init n_hdlc_init(void)
 {
@@ -973,8 +971,6 @@ static int __init n_hdlc_init(void)
 	else
 		printk(hdlc_register_fail, status);
 
-	if (status)
-		printk(hdlc_init_fail, status);
 	return status;
 	
 }	/* end of init_module() */

-- 
Jean Delvare
SUSE L3 Support

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-04-25  9:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-25  9:02 [PATCH] tty: n_hdlc: Drop redundant error message Jean Delvare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®