* [PATCH 1/1] fs/affs/super.c: bugfix / double free
@ 2014-05-04 6:36 Fabian Frederick
0 siblings, 0 replies; only message in thread
From: Fabian Frederick @ 2014-05-04 6:36 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, Viro
842a859db26b70
("affs: use ->kill_sb() to simplify ->put_super() and failure exits of ->mount()")
adds .kill_sb which frees sbi but doesn't remove sbi free in case of parse_options
error causing double free+random crash.
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/affs/super.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/affs/super.c b/fs/affs/super.c
index 6d589f2..895ac7d 100644
--- a/fs/affs/super.c
+++ b/fs/affs/super.c
@@ -340,8 +340,6 @@ static int affs_fill_super(struct super_block *sb, void *data, int silent)
&blocksize,&sbi->s_prefix,
sbi->s_volume, &mount_flags)) {
printk(KERN_ERR "AFFS: Error parsing options\n");
- kfree(sbi->s_prefix);
- kfree(sbi);
return -EINVAL;
}
/* N.B. after this point s_prefix must be released */
--
1.8.4.5
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-05-04 6:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-04 6:36 [PATCH 1/1] fs/affs/super.c: bugfix / double free Fabian Frederick
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®