* [PATCH 1/1] kernel/time/ntp.c: convert simple_strtol to kstrtol
@ 2014-05-09 18:14 Fabian Frederick
2014-05-09 18:17 ` John Stultz
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-05-09 18:14 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, John Stultz
Inspired-By: Andrew Morton <akpm@linux-foundation.org>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
kernel/time/ntp.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
index 419a52c..82b7c9e 100644
--- a/kernel/time/ntp.c
+++ b/kernel/time/ntp.c
@@ -923,7 +923,10 @@ void __hardpps(const struct timespec *phase_ts, const struct timespec *raw_ts)
static int __init ntp_tick_adj_setup(char *str)
{
- ntp_tick_adj = simple_strtol(str, NULL, 0);
+ int rc = kstrtol(str, 0, (long *)&ntp_tick_adj);
+
+ if (rc)
+ return rc;
ntp_tick_adj <<= NTP_SCALE_SHIFT;
return 1;
--
1.8.4.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] kernel/time/ntp.c: convert simple_strtol to kstrtol
2014-05-09 18:14 [PATCH 1/1] kernel/time/ntp.c: convert simple_strtol to kstrtol Fabian Frederick
@ 2014-05-09 18:17 ` John Stultz
0 siblings, 0 replies; 2+ messages in thread
From: John Stultz @ 2014-05-09 18:17 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, akpm
On Fri, May 9, 2014 at 11:14 AM, Fabian Frederick <fabf@skynet.be> wrote:
>
Commit message missing. Mind adding a brief description of why this
change is worth making?
> Inspired-By: Andrew Morton <akpm@linux-foundation.org>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> kernel/time/ntp.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
> index 419a52c..82b7c9e 100644
> --- a/kernel/time/ntp.c
> +++ b/kernel/time/ntp.c
> @@ -923,7 +923,10 @@ void __hardpps(const struct timespec *phase_ts, const struct timespec *raw_ts)
>
> static int __init ntp_tick_adj_setup(char *str)
> {
> - ntp_tick_adj = simple_strtol(str, NULL, 0);
> + int rc = kstrtol(str, 0, (long *)&ntp_tick_adj);
> +
> + if (rc)
> + return rc;
> ntp_tick_adj <<= NTP_SCALE_SHIFT;
>
> return 1;
> --
> 1.8.4.5
>
thanks
-john
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-09 18:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-09 18:14 [PATCH 1/1] kernel/time/ntp.c: convert simple_strtol to kstrtol Fabian Frederick
2014-05-09 18:17 ` John Stultz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®