* [PATCH cgroup/for-3.16] cgroup: fix rcu_read_lock() leak in update_if_frozen()
[not found] <5369104d.Nn5Lpp7nwOehwnnC%fengguang.wu@intel.com>
@ 2014-05-10 3:29 ` Tejun Heo
2014-05-13 15:34 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2014-05-10 3:29 UTC (permalink / raw)
To: Li Zefan; +Cc: kbuild test robot, cgroups, linux-kernel
While updating cgroup_freezer locking, 68fafb77d827 ("cgroup_freezer:
replace freezer->lock with freezer_mutex") introduced a bug in
update_if_frozen() where it returns with rcu_read_lock() held. Fix it
by adding rcu_read_unlock() before returning.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
---
kernel/cgroup_freezer.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/kernel/cgroup_freezer.c
+++ b/kernel/cgroup_freezer.c
@@ -267,8 +267,10 @@ static void update_if_frozen(struct cgro
struct freezer *child = css_freezer(pos);
if ((child->state & CGROUP_FREEZER_ONLINE) &&
- !(child->state & CGROUP_FROZEN))
+ !(child->state & CGROUP_FROZEN)) {
+ rcu_read_unlock();
return;
+ }
}
rcu_read_unlock();
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH cgroup/for-3.16] cgroup: fix rcu_read_lock() leak in update_if_frozen()
2014-05-10 3:29 ` [PATCH cgroup/for-3.16] cgroup: fix rcu_read_lock() leak in update_if_frozen() Tejun Heo
@ 2014-05-13 15:34 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2014-05-13 15:34 UTC (permalink / raw)
To: Li Zefan; +Cc: kbuild test robot, cgroups, linux-kernel
On Fri, May 09, 2014 at 11:29:41PM -0400, Tejun Heo wrote:
> While updating cgroup_freezer locking, 68fafb77d827 ("cgroup_freezer:
> replace freezer->lock with freezer_mutex") introduced a bug in
> update_if_frozen() where it returns with rcu_read_lock() held. Fix it
> by adding rcu_read_unlock() before returning.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
Applied to cgroup/for-3.15-fixes.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-13 15:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <5369104d.Nn5Lpp7nwOehwnnC%fengguang.wu@intel.com>
2014-05-10 3:29 ` [PATCH cgroup/for-3.16] cgroup: fix rcu_read_lock() leak in update_if_frozen() Tejun Heo
2014-05-13 15:34 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®