mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Cc: paulmck@linux.vnet.ibm.com, peterz@infradead.org,
	tglx@linutronix.de, mingo@kernel.org, rusty@rustcorp.com.au,
	akpm@linux-foundation.org, fweisbec@gmail.com, hch@infradead.org,
	mgorman@suse.de, riel@redhat.com, bp@suse.de,
	rostedt@goodmis.org, mgalbraith@suse.de, ego@linux.vnet.ibm.com,
	oleg@redhat.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 UPDATED 3/3] CPU hotplug, smp: Flush any pending IPI callbacks before CPU offline
Date: Thu, 15 May 2014 15:45:23 -0400	[thread overview]
Message-ID: <20140515194523.GD21306@htj.dyndns.org> (raw)
In-Reply-To: <537518D6.6030006@linux.vnet.ibm.com>

On Fri, May 16, 2014 at 01:13:18AM +0530, Srivatsa S. Bhat wrote:
> On 05/16/2014 01:06 AM, Paul E. McKenney wrote:
> > On Fri, May 16, 2014 at 12:56:11AM +0530, Srivatsa S. Bhat wrote:
> >> On 05/16/2014 12:49 AM, Tejun Heo wrote:
> >>> Hello,
> >>>
> >>> On Fri, May 16, 2014 at 12:44:13AM +0530, Srivatsa S. Bhat wrote:
> >>>>  /*
> >>>> + * flush_smp_call_function_queue - Flush any pending smp-call-function
> >>>
> >>> Don't we need a blank line here?
> >>
> >> Hmm? That sentence continues on the next line, hence I didn't add any blank
> >> line there.
> > 
> > Tejun might be wanting this to be a docbook comment, in which case
> > it also needs "/**" at the beginning of the comment.
> > 
> 
> Oh, I see. Like this?

Yeah, looks good to me.

Thanks.

-- 
tejun

  reply	other threads:[~2014-05-15 19:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15 19:12 [PATCH v5 0/3] CPU hotplug: Fix the long-standing "IPI to offline CPU" issue Srivatsa S. Bhat
2014-05-15 19:13 ` [PATCH v5 1/3] smp: Print more useful debug info upon receiving IPI on an offline CPU Srivatsa S. Bhat
2014-05-15 19:19   ` Joe Perches
2014-05-15 19:34     ` Srivatsa S. Bhat
2014-05-15 19:43       ` Joe Perches
2014-05-15 19:51         ` [PATCH v5 UPDATED " Srivatsa S. Bhat
2014-05-15 19:13 ` [PATCH v5 2/3] CPU hotplug, stop-machine: Plug race-window that leads to "IPI-to-offline-CPU" Srivatsa S. Bhat
2014-05-15 19:17   ` Tejun Heo
2014-05-15 19:18     ` Srivatsa S. Bhat
2014-05-15 19:14 ` [PATCH v5 3/3] CPU hotplug, smp: Flush any pending IPI callbacks before CPU offline Srivatsa S. Bhat
2014-05-15 19:19   ` Tejun Heo
2014-05-15 19:26     ` Srivatsa S. Bhat
2014-05-15 19:36       ` Paul E. McKenney
2014-05-15 19:43         ` [PATCH v5 UPDATED " Srivatsa S. Bhat
2014-05-15 19:45           ` Tejun Heo [this message]
2014-05-19 12:19           ` [PATCH v5 UPDATEDv2 " Srivatsa S. Bhat
2014-05-19 16:18             ` Oleg Nesterov
2014-05-19 19:49               ` Srivatsa S. Bhat
2014-05-19 20:22                 ` [PATCH v5 UPDATEDv3 " Srivatsa S. Bhat
2014-05-20  9:42                   ` Peter Zijlstra
2014-05-20 10:09                     ` Srivatsa S. Bhat
2014-05-20 10:25                       ` Peter Zijlstra
2014-05-20 10:31                         ` Srivatsa S. Bhat
2014-05-20 10:38                           ` Srivatsa S. Bhat
2014-05-20 10:42                             ` Srivatsa S. Bhat
2014-05-15 19:44         ` [PATCH v5 " Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140515194523.GD21306@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bp@suse.de \
    --cc=ego@linux.vnet.ibm.com \
    --cc=fweisbec@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgalbraith@suse.de \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=rostedt@goodmis.org \
    --cc=rusty@rustcorp.com.au \
    --cc=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome