From: Jake Edge <jake@lwn.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Anton Saraev <antonysaraev@gmail.com>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
jason@lakedaemon.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 02/06] staging: crypto: skein: rename camelcase vars
Date: Mon, 19 May 2014 13:44:18 -0600 [thread overview]
Message-ID: <20140519134418.23f917fe@chukar.edge2.net> (raw)
In-Reply-To: <20140519192112.GT16255@mwanda>
On Mon, 19 May 2014 22:21:12 +0300 Dan Carpenter wrote:
> So, Jake, you're right, but if he redoes patch 2/6 then he has to redo
> the rest as well. The bad names were bad in the original code already,
> so normally we let people fix things up in follow on patches in that
> case.
>
> Is that ok with you?
Sure, that seems fine ... I only had fairly minor quibbles, the vast
majority of it is good stuff ...
Not sure it's useful (or even the right way to go about it), but, if it
is, Greg (or Jason or whoever) can add my:
Reviewed-by: Jake Edge <jake@lwn.net>
to the patch set ...
jake
--
Jake Edge - LWN - jake@lwn.net - http://lwn.net
next prev parent reply other threads:[~2014-05-19 19:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 8:09 [PATCH v2 00/06] staging: crypto: skein: fixing style issues Anton Saraev
2014-05-19 8:09 ` [PATCH v2 01/06] staging: crypto: skein: rename camelcase functions Anton Saraev
2014-05-19 8:09 ` [PATCH v2 02/06] staging: crypto: skein: rename camelcase vars Anton Saraev
2014-05-19 8:09 ` [PATCH v2 03/06] staging: crypto: skein: rename skein1024_ctx to skein_1024_ctx Anton Saraev
2014-05-19 8:09 ` [PATCH v2 04/06] staging: crypto: skein: rename enums Anton Saraev
2014-05-19 8:09 ` [PATCH v2 05/06] staging: crypto: skein: rename macros Anton Saraev
2014-05-19 8:09 ` [PATCH v2 06/06] staging: crypto: skein: rename files Anton Saraev
2014-05-19 13:29 ` Jake Edge
2014-05-19 14:05 ` Jason Cooper
2014-05-19 13:45 ` Jake Edge
2014-05-19 22:22 ` Greg KH
2014-05-19 9:08 ` [PATCH v2 05/06] staging: crypto: skein: rename macros Dan Carpenter
2014-05-19 14:04 ` Jason Cooper
2014-05-19 9:02 ` [PATCH v2 02/06] staging: crypto: skein: rename camelcase vars Dan Carpenter
2014-05-19 14:40 ` Jake Edge
2014-05-19 19:21 ` Dan Carpenter
2014-05-19 19:44 ` Jake Edge [this message]
2014-05-19 19:55 ` Dan Carpenter
2014-05-19 8:53 ` [PATCH v2 00/06] staging: crypto: skein: fixing style issues Dan Carpenter
2014-05-19 14:11 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519134418.23f917fe@chukar.edge2.net \
--to=jake@lwn.net \
--cc=antonysaraev@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome