From: Jake Edge <jake@lwn.net>
To: Anton Saraev <antonysaraev@gmail.com>
Cc: gregkh@linuxfoundation.org, jason@lakedaemon.net,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 06/06] staging: crypto: skein: rename files
Date: Mon, 19 May 2014 07:45:10 -0600 [thread overview]
Message-ID: <20140519074510.74e622fd@chukar.edge2.net> (raw)
In-Reply-To: <a5204985750d7adf9b20752f889fbf2a2147de94.1399675445.git.antonysaraev@gmail.com>
On Mon, 19 May 2014 12:09:59 +0400 Anton Saraev wrote:
> --- a/drivers/staging/skein/Makefile
> +++ b/drivers/staging/skein/Makefile
> @@ -4,10 +4,10 @@
> subdir-ccflags-y := -I$(src)/include/
as part of the rearranging of files, I think you want to get rid of
this include directory, move the files up to the main directory and
include them as "skein.h" (rather than <skein.h>).
Then this line can be removed from the Makefile.
> --- a/drivers/staging/skein/threefish1024Block.c
> +++ b/drivers/staging/skein/threefish_1024_block.c
> @@ -1,5 +1,5 @@
> #include <linux/string.h>
> -#include <threefishApi.h>
> +#include <threefish_api.h>
incidentally, none of the threefish_*_block.c files actually needs
linux/string.h ... there may be other files where that's true too, it
seems to have just gotten added everywhere ...
jake
--
Jake Edge - LWN - jake@lwn.net - http://lwn.net
next prev parent reply other threads:[~2014-05-19 13:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 8:09 [PATCH v2 00/06] staging: crypto: skein: fixing style issues Anton Saraev
2014-05-19 8:09 ` [PATCH v2 01/06] staging: crypto: skein: rename camelcase functions Anton Saraev
2014-05-19 8:09 ` [PATCH v2 02/06] staging: crypto: skein: rename camelcase vars Anton Saraev
2014-05-19 8:09 ` [PATCH v2 03/06] staging: crypto: skein: rename skein1024_ctx to skein_1024_ctx Anton Saraev
2014-05-19 8:09 ` [PATCH v2 04/06] staging: crypto: skein: rename enums Anton Saraev
2014-05-19 8:09 ` [PATCH v2 05/06] staging: crypto: skein: rename macros Anton Saraev
2014-05-19 8:09 ` [PATCH v2 06/06] staging: crypto: skein: rename files Anton Saraev
2014-05-19 13:29 ` Jake Edge
2014-05-19 14:05 ` Jason Cooper
2014-05-19 13:45 ` Jake Edge [this message]
2014-05-19 22:22 ` Greg KH
2014-05-19 9:08 ` [PATCH v2 05/06] staging: crypto: skein: rename macros Dan Carpenter
2014-05-19 14:04 ` Jason Cooper
2014-05-19 9:02 ` [PATCH v2 02/06] staging: crypto: skein: rename camelcase vars Dan Carpenter
2014-05-19 14:40 ` Jake Edge
2014-05-19 19:21 ` Dan Carpenter
2014-05-19 19:44 ` Jake Edge
2014-05-19 19:55 ` Dan Carpenter
2014-05-19 8:53 ` [PATCH v2 00/06] staging: crypto: skein: fixing style issues Dan Carpenter
2014-05-19 14:11 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519074510.74e622fd@chukar.edge2.net \
--to=jake@lwn.net \
--cc=antonysaraev@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome