* [PATCH] workqueue: remove unused work_clear_pending()
@ 2014-05-22 8:43 Lai Jiangshan
2014-05-22 15:39 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Lai Jiangshan @ 2014-05-22 8:43 UTC (permalink / raw)
To: linux-kernel; +Cc: Tejun Heo, Lai Jiangshan
In 8930caba, setting last CPU and clearing PENDING got merged into a single
operation (set_work_cpu_and_clear_pending()), which resulted that the
internal routine work_clear_pending() is not used any more.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
include/linux/workqueue.h | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index 860fcca..89b662b 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -273,13 +273,6 @@ static inline unsigned int work_static(struct work_struct *work) { return 0; }
#define delayed_work_pending(w) \
work_pending(&(w)->work)
-/**
- * work_clear_pending - for internal use only, mark a work item as not pending
- * @work: The work item in question
- */
-#define work_clear_pending(work) \
- clear_bit(WORK_STRUCT_PENDING_BIT, work_data_bits(work))
-
/*
* Workqueue flags and constants. For details, please refer to
* Documentation/workqueue.txt.
--
1.7.4.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] workqueue: remove unused work_clear_pending()
2014-05-22 8:43 [PATCH] workqueue: remove unused work_clear_pending() Lai Jiangshan
@ 2014-05-22 15:39 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2014-05-22 15:39 UTC (permalink / raw)
To: Lai Jiangshan; +Cc: linux-kernel
On Thu, May 22, 2014 at 04:43:56PM +0800, Lai Jiangshan wrote:
> In 8930caba, setting last CPU and clearing PENDING got merged into a single
Ditto.
> operation (set_work_cpu_and_clear_pending()), which resulted that the
> internal routine work_clear_pending() is not used any more.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Applied to wq/for-3.16.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-22 15:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-22 8:43 [PATCH] workqueue: remove unused work_clear_pending() Lai Jiangshan
2014-05-22 15:39 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®