* [PATCH RESEND] sysfs: fix attribute_group bin file path on removal
@ 2014-05-22 17:15 Robert ABEL
2014-05-22 17:15 ` Robert ABEL
2014-05-23 2:30 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Robert ABEL @ 2014-05-22 17:15 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh
I sent this patch to the list on 15 Apr 14.
However, no activity since. Should I have sent this patch somewhere else?
Regards,
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH RESEND] sysfs: fix attribute_group bin file path on removal
2014-05-22 17:15 [PATCH RESEND] sysfs: fix attribute_group bin file path on removal Robert ABEL
@ 2014-05-22 17:15 ` Robert ABEL
2014-05-23 2:30 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Robert ABEL @ 2014-05-22 17:15 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, Robert ABEL
Cody Schafer already fixed binary file creation for attribute groups, see [1].
This patch makes the appropriate changes for binary file removal
of attribute groups.
[1]: http://lkml.org/lkml/2014/2/27/832
Signed-off-by: Robert ABEL <rabel@cit-ec.uni-bielefeld.de>
---
fs/sysfs/group.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c
index aa04068..7d2a860 100644
--- a/fs/sysfs/group.c
+++ b/fs/sysfs/group.c
@@ -18,7 +18,7 @@
#include "sysfs.h"
-static void remove_files(struct kernfs_node *parent, struct kobject *kobj,
+static void remove_files(struct kernfs_node *parent,
const struct attribute_group *grp)
{
struct attribute *const *attr;
@@ -29,7 +29,7 @@ static void remove_files(struct kernfs_node *parent, struct kobject *kobj,
kernfs_remove_by_name(parent, (*attr)->name);
if (grp->bin_attrs)
for (bin_attr = grp->bin_attrs; *bin_attr; bin_attr++)
- sysfs_remove_bin_file(kobj, *bin_attr);
+ kernfs_remove_by_name(parent, (*bin_attr)->attr.name);
}
static int create_files(struct kernfs_node *parent, struct kobject *kobj,
@@ -62,7 +62,7 @@ static int create_files(struct kernfs_node *parent, struct kobject *kobj,
break;
}
if (error) {
- remove_files(parent, kobj, grp);
+ remove_files(parent, grp);
goto exit;
}
}
@@ -79,7 +79,7 @@ static int create_files(struct kernfs_node *parent, struct kobject *kobj,
break;
}
if (error)
- remove_files(parent, kobj, grp);
+ remove_files(parent, grp);
}
exit:
return error;
@@ -224,7 +224,7 @@ void sysfs_remove_group(struct kobject *kobj,
kernfs_get(kn);
}
- remove_files(kn, kobj, grp);
+ remove_files(kn, grp);
if (grp->name)
kernfs_remove(kn);
--
1.9.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] sysfs: fix attribute_group bin file path on removal
2014-05-22 17:15 [PATCH RESEND] sysfs: fix attribute_group bin file path on removal Robert ABEL
2014-05-22 17:15 ` Robert ABEL
@ 2014-05-23 2:30 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2014-05-23 2:30 UTC (permalink / raw)
To: Robert ABEL; +Cc: linux-kernel
On Thu, May 22, 2014 at 07:15:11PM +0200, Robert ABEL wrote:
> I sent this patch to the list on 15 Apr 14.
> However, no activity since. Should I have sent this patch somewhere else?
I have it in my todo queue, sorry for the delay, I've been on the road
for 3 weeks and will be home next week and start to catch up.
Don't worry, it's not lost.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH RESEND] sysfs: fix attribute_group bin file path on removal
@ 2014-05-05 13:17 Robert ABEL
0 siblings, 0 replies; 4+ messages in thread
From: Robert ABEL @ 2014-05-05 13:17 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, Robert ABEL
Cody Schafer already fixed binary file creation for attribute groups, see [1].
This patch makes the appropriate changes for binary file removal
of attribute groups.
[1]: http://lkml.org/lkml/2014/2/27/832
Signed-off-by: Robert ABEL <rabel@cit-ec.uni-bielefeld.de>
---
fs/sysfs/group.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c
index aa04068..7d2a860 100644
--- a/fs/sysfs/group.c
+++ b/fs/sysfs/group.c
@@ -18,7 +18,7 @@
#include "sysfs.h"
-static void remove_files(struct kernfs_node *parent, struct kobject *kobj,
+static void remove_files(struct kernfs_node *parent,
const struct attribute_group *grp)
{
struct attribute *const *attr;
@@ -29,7 +29,7 @@ static void remove_files(struct kernfs_node *parent, struct kobject *kobj,
kernfs_remove_by_name(parent, (*attr)->name);
if (grp->bin_attrs)
for (bin_attr = grp->bin_attrs; *bin_attr; bin_attr++)
- sysfs_remove_bin_file(kobj, *bin_attr);
+ kernfs_remove_by_name(parent, (*bin_attr)->attr.name);
}
static int create_files(struct kernfs_node *parent, struct kobject *kobj,
@@ -62,7 +62,7 @@ static int create_files(struct kernfs_node *parent, struct kobject *kobj,
break;
}
if (error) {
- remove_files(parent, kobj, grp);
+ remove_files(parent, grp);
goto exit;
}
}
@@ -79,7 +79,7 @@ static int create_files(struct kernfs_node *parent, struct kobject *kobj,
break;
}
if (error)
- remove_files(parent, kobj, grp);
+ remove_files(parent, grp);
}
exit:
return error;
@@ -224,7 +224,7 @@ void sysfs_remove_group(struct kobject *kobj,
kernfs_get(kn);
}
- remove_files(kn, kobj, grp);
+ remove_files(kn, grp);
if (grp->name)
kernfs_remove(kn);
--
1.9.2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-23 2:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-22 17:15 [PATCH RESEND] sysfs: fix attribute_group bin file path on removal Robert ABEL
2014-05-22 17:15 ` Robert ABEL
2014-05-23 2:30 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-05-05 13:17 Robert ABEL
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®