* [PATCH v2] regulator: s2mpa01: Use correct register for buck1 ramp delay
@ 2014-05-26 8:26 Krzysztof Kozlowski
2014-05-26 8:40 ` Sachin Kamat
2014-05-26 14:39 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2014-05-26 8:26 UTC (permalink / raw)
To: Sangbeom Kim, Liam Girdwood, Mark Brown, Sachin Kamat, linux-kernel
Cc: Axel Lin, Krzysztof Kozlowski, stable
Fix the register for ramp delay of buck1 regulator. Buck1 and buck6
share the field (offset 4) in ramp delay register S2MPA01_REG_RAMP2.
The driver used the same register and field for ramp delay of buck3 and
buck1. This lead to updating of ramp delay of buck3 when setting buck1
and actually the ramp delay of buck1 was never set.
Cc: <stable@vger.kernel.org>
Fixes: f18792714608 ("regulator: Add support for S2MPA01 regulator")
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
Changes since v1:
1. Adjust the patch to match datasheet of S2MPA01.
---
drivers/regulator/s2mpa01.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/regulator/s2mpa01.c b/drivers/regulator/s2mpa01.c
index f19a30f0fb42..a52cb1cec576 100644
--- a/drivers/regulator/s2mpa01.c
+++ b/drivers/regulator/s2mpa01.c
@@ -116,7 +116,6 @@ static int s2mpa01_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
ramp_delay = s2mpa01->ramp_delay16;
ramp_shift = S2MPA01_BUCK16_RAMP_SHIFT;
- ramp_reg = S2MPA01_REG_RAMP1;
break;
case S2MPA01_BUCK2:
enable_shift = S2MPA01_BUCK2_RAMP_EN_SHIFT;
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] regulator: s2mpa01: Use correct register for buck1 ramp delay
2014-05-26 8:26 [PATCH v2] regulator: s2mpa01: Use correct register for buck1 ramp delay Krzysztof Kozlowski
@ 2014-05-26 8:40 ` Sachin Kamat
2014-05-26 14:39 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Sachin Kamat @ 2014-05-26 8:40 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Sangbeom Kim, Liam Girdwood, Mark Brown, LKML, Axel Lin, stable
On 26 May 2014 13:56, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> Fix the register for ramp delay of buck1 regulator. Buck1 and buck6
> share the field (offset 4) in ramp delay register S2MPA01_REG_RAMP2.
>
> The driver used the same register and field for ramp delay of buck3 and
> buck1. This lead to updating of ramp delay of buck3 when setting buck1
> and actually the ramp delay of buck1 was never set.
>
> Cc: <stable@vger.kernel.org>
> Fixes: f18792714608 ("regulator: Add support for S2MPA01 regulator")
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Sachin Kamat <sachin.kamat@linaro.org>
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] regulator: s2mpa01: Use correct register for buck1 ramp delay
2014-05-26 8:26 [PATCH v2] regulator: s2mpa01: Use correct register for buck1 ramp delay Krzysztof Kozlowski
2014-05-26 8:40 ` Sachin Kamat
@ 2014-05-26 14:39 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-05-26 14:39 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Sangbeom Kim, Liam Girdwood, Sachin Kamat, linux-kernel,
Axel Lin, stable
[-- Attachment #1: Type: text/plain, Size: 228 bytes --]
On Mon, May 26, 2014 at 10:26:46AM +0200, Krzysztof Kozlowski wrote:
> Fix the register for ramp delay of buck1 regulator. Buck1 and buck6
> share the field (offset 4) in ramp delay register S2MPA01_REG_RAMP2.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-26 14:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-26 8:26 [PATCH v2] regulator: s2mpa01: Use correct register for buck1 ramp delay Krzysztof Kozlowski
2014-05-26 8:40 ` Sachin Kamat
2014-05-26 14:39 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®