* [PATCH] gpio: pch: include linux/slab.h
@ 2014-05-26 15:04 Arnd Bergmann
2014-05-26 15:34 ` Jean Delvare
2014-05-27 13:59 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2014-05-26 15:04 UTC (permalink / raw)
To: Linus Walleij
Cc: Jean Delvare, Alexandre Courbot, linux-kernel, linux-arm-kernel
The gpio-pch driver was recently enabled for compile-tests,
which revealed that it is missing an include for linux/slab.h,
which on ARM is not implied by any of the other headers.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index 83a1563..d6eac9b 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -20,6 +20,7 @@
#include <linux/gpio.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
+#include <linux/slab.h>
#define PCH_EDGE_FALLING 0
#define PCH_EDGE_RISING BIT(0)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: pch: include linux/slab.h
2014-05-26 15:04 [PATCH] gpio: pch: include linux/slab.h Arnd Bergmann
@ 2014-05-26 15:34 ` Jean Delvare
2014-05-27 13:59 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2014-05-26 15:34 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linus Walleij, Alexandre Courbot, linux-kernel, linux-arm-kernel
On Mon, 26 May 2014 17:04:24 +0200, Arnd Bergmann wrote:
> The gpio-pch driver was recently enabled for compile-tests,
> which revealed that it is missing an include for linux/slab.h,
> which on ARM is not implied by any of the other headers.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
> index 83a1563..d6eac9b 100644
> --- a/drivers/gpio/gpio-pch.c
> +++ b/drivers/gpio/gpio-pch.c
> @@ -20,6 +20,7 @@
> #include <linux/gpio.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> +#include <linux/slab.h>
>
> #define PCH_EDGE_FALLING 0
> #define PCH_EDGE_RISING BIT(0)
>
Good catch, thanks Arnd.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: pch: include linux/slab.h
2014-05-26 15:04 [PATCH] gpio: pch: include linux/slab.h Arnd Bergmann
2014-05-26 15:34 ` Jean Delvare
@ 2014-05-27 13:59 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2014-05-27 13:59 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jean Delvare, Alexandre Courbot, linux-kernel, linux-arm-kernel
On Mon, May 26, 2014 at 5:04 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The gpio-pch driver was recently enabled for compile-tests,
> which revealed that it is missing an include for linux/slab.h,
> which on ARM is not implied by any of the other headers.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Oh I fixed that up as I was going over the failed build logs.
Sorry that I didn't see this first, thanks anyway!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-27 13:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-26 15:04 [PATCH] gpio: pch: include linux/slab.h Arnd Bergmann
2014-05-26 15:34 ` Jean Delvare
2014-05-27 13:59 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®