From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Paul Bolle <pebolle@tiscali.nl>,
linux-arm-kernel@lists.infradead.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] acornscsi: remove linked command support
Date: Wed, 28 May 2014 16:17:39 +0100 [thread overview]
Message-ID: <20140528151739.GJ3693@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1401287204.2288.28.camel@dabdike>
On Wed, May 28, 2014 at 06:26:44PM +0400, James Bottomley wrote:
> On Wed, 2014-05-28 at 03:41 -0700, Christoph Hellwig wrote:
> > Looks good,
> >
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> >
> > And I have to disagree with James here, removing code that isn't even
> > compiled always is an improvement, especially for an unmaintained
> > driver.
>
> Well, as I said, this is in theory a maintained driver, so just get an
> ack from Russell and this debate is moot.
I don't see any harm in removing this - I don't think I've owned any
SCSI devices which supported linked commands, which is why I never
put much effort into it. As no one else seems to care about it (given
the number of years it's been left alone), removing the linked command
stuff is fine.
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
prev parent reply other threads:[~2014-05-28 15:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 10:13 Paul Bolle
2014-05-24 10:35 ` Hannes Reinecke
2014-05-24 12:13 ` James Bottomley
2014-05-24 13:16 ` Paul Bolle
2014-05-25 7:42 ` James Bottomley
2014-05-28 17:28 ` Paul Bolle
2014-05-28 10:41 ` Christoph Hellwig
2014-05-28 14:26 ` James Bottomley
2014-05-28 15:17 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528151739.GJ3693@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hch@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®