From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Alexandre Courbot <gnurou@gmail.com>,
"Zhu, Lejun" <lejun.zhu@linux.intel.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
jacob.jun.pan@linux.intel.com, bin.yang@intel.com
Subject: Re: [PATCH v4] gpio: Add support for Intel SoC PMIC (Crystal Cove)
Date: Tue, 3 Jun 2014 13:57:10 +0300 [thread overview]
Message-ID: <20140603105710.GF1730@lahna.fi.intel.com> (raw)
In-Reply-To: <CACRpkdar8jUuQHg7q5rPmGQ2tdomBgXcPA5OUT-n3iLh5Ca11w@mail.gmail.com>
On Tue, Jun 03, 2014 at 10:10:13AM +0200, Linus Walleij wrote:
> On Fri, May 30, 2014 at 10:25 AM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
>
> > I'm thinking that could we solve this so that we call
> > acpi_gpiochip_request_interrupts() at the end of gpiochip_irqchip_add()
> > and convert both pinctrl-baytrail and gpio-lynxpoint to use
> > gpiochip_irqchip_add()?
>
> Yes that seems like a great way to solve it actually.
>
> Is someone able to do this refactoring?
I have both Haswell and Baytrail hardware here so I can take a look if I
have time.
> I don't know if you have a case of an ACPI-based GPIO controller
> that is *not* supplying interrupts? Because in that case this
> would even be required for the thing to work, right?
Both Haswell and Baytrail support interrupts but only the later provides
ACPI events as far as I can tell.
next prev parent reply other threads:[~2014-06-03 10:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 2:00 Zhu, Lejun
2014-05-27 5:38 ` Alexandre Courbot
2014-05-27 6:15 ` Alexandre Courbot
2014-05-27 6:22 ` Zhu, Lejun
2014-05-27 9:24 ` Grygorii Strashko
2014-05-27 8:46 ` Mika Westerberg
2014-05-27 12:04 ` Grygorii Strashko
2014-05-27 15:14 ` Mika Westerberg
2014-05-29 13:37 ` Linus Walleij
2014-05-29 15:00 ` Mika Westerberg
2014-05-29 16:03 ` Grygorii Strashko
2014-05-29 15:22 ` Linus Walleij
2014-05-30 8:25 ` Mika Westerberg
2014-06-03 8:10 ` Linus Walleij
2014-06-03 10:57 ` Mika Westerberg [this message]
2014-05-30 2:12 ` Zhu, Lejun
2014-06-03 8:08 ` Linus Walleij
2014-05-27 8:56 ` Zhu, Lejun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603105710.GF1730@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=bin.yang@intel.com \
--cc=gnurou@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=lejun.zhu@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome