* [patchlet][resend] sched: Fix up /proc/sched_debug to print only runnable tasks again
@ 2014-06-03 13:14 Mike Galbraith
2014-06-03 14:34 ` Peter Zijlstra
0 siblings, 1 reply; 2+ messages in thread
From: Mike Galbraith @ 2014-06-03 13:14 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: LKML, Ingo Molnar
Commit b32e86b430 dropped p->on_rq check, leading to printing tasks which
used to live on runqueues, which is very noisy and highly annoying.
Signed-off-by: Mike Galbraith <bitbucket@online.de>
---
kernel/sched/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -162,7 +162,7 @@ static void print_rq(struct seq_file *m,
read_lock_irqsave(&tasklist_lock, flags);
do_each_thread(g, p) {
- if (task_cpu(p) != rq_cpu)
+ if (!p->on_rq || task_cpu(p) != rq_cpu)
continue;
print_task(m, rq, p);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patchlet][resend] sched: Fix up /proc/sched_debug to print only runnable tasks again
2014-06-03 13:14 [patchlet][resend] sched: Fix up /proc/sched_debug to print only runnable tasks again Mike Galbraith
@ 2014-06-03 14:34 ` Peter Zijlstra
0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2014-06-03 14:34 UTC (permalink / raw)
To: Mike Galbraith; +Cc: LKML, Ingo Molnar
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
On Tue, Jun 03, 2014 at 03:14:21PM +0200, Mike Galbraith wrote:
>
> Commit b32e86b430 dropped p->on_rq check, leading to printing tasks which
> used to live on runqueues, which is very noisy and highly annoying.
Yes,.. but also useful for the numa cruft :-(
When printing all we can get placement info for !running tasks.
Not sure what to do here..
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-03 14:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-03 13:14 [patchlet][resend] sched: Fix up /proc/sched_debug to print only runnable tasks again Mike Galbraith
2014-06-03 14:34 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®