From: Peter Zijlstra <peterz@infradead.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
nicolas.pitre@linaro.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Mike Galbraith <umgwanakikbuti@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH 0/8] sched,idle: need resched polling rework
Date: Tue, 3 Jun 2014 20:28:50 +0200 [thread overview]
Message-ID: <20140603182850.GJ16155@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <20140603170018.GD30445@twins.programming.kicks-ass.net>
On Tue, Jun 03, 2014 at 07:00:18PM +0200, Peter Zijlstra wrote:
> On Tue, Jun 03, 2014 at 09:52:22AM -0700, Andy Lutomirski wrote:
> > > So you could cheat and set it in pick_next_task_idle() and clear in
> > > put_prev_task_idle(), that way the entire idle loop, when running has it
> > > set.
> > >
> >
> > Isn't that a little late for sched_ttwu_pending? I guess it could be
> > okay, but I'm hesitant to muck around with the scheduler innards that
> > much. I don't see anything that'll break, though.
>
> Yeah, only later did I see you clear much earlier, which makes sense.
Could we clear it from set_nr_and_not_polling()/set_nr_if_polling()?
That's the only two functions that'll kick a cpu out of its polling
loop, and we're already writing to the word anyhow.
next prev parent reply other threads:[~2014-06-03 18:29 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 13:42 Peter Zijlstra
2014-04-11 13:42 ` [RFC][PATCH 1/8] sched,idle,alpha: Switch from TS_POLLING to TIF_POLLING_NRFLAG Peter Zijlstra
2014-04-11 14:38 ` Richard Henderson
2014-04-11 13:42 ` [RFC][PATCH 2/8] sched,idle,tile: " Peter Zijlstra
2014-04-11 15:15 ` Chris Metcalf
2014-04-11 15:30 ` Peter Zijlstra
2014-04-11 13:42 ` [RFC][PATCH 3/8] sched,idle,ia64: " Peter Zijlstra
2014-04-11 13:42 ` [RFC][PATCH 4/8] sched,idle,x86: " Peter Zijlstra
2014-04-11 13:42 ` [RFC][PATCH 5/8] sched,idle: Remove TS_POLLING support Peter Zijlstra
2014-04-11 13:42 ` [RFC][PATCH 6/8] sched,idle: Avoid spurious wakeup IPIs Peter Zijlstra
2014-04-13 21:41 ` Nicolas Pitre
2014-05-09 13:37 ` James Hogan
2014-05-09 14:15 ` Peter Zijlstra
2014-05-09 14:40 ` Catalin Marinas
2014-05-09 14:50 ` Peter Zijlstra
2014-05-09 14:57 ` Catalin Marinas
2014-05-09 17:02 ` Peter Zijlstra
2014-05-09 17:06 ` Peter Zijlstra
2014-05-09 17:09 ` Catalin Marinas
2014-05-09 17:20 ` Peter Zijlstra
2014-05-19 12:54 ` [tip:sched/arch] arm64: Remove TIF_POLLING_NRFLAG tip-bot for Peter Zijlstra
2014-05-22 12:26 ` [tip:sched/core] " tip-bot for Peter Zijlstra
2014-05-09 14:51 ` [RFC][PATCH 6/8] sched,idle: Avoid spurious wakeup IPIs James Hogan
2014-05-15 9:17 ` James Hogan
2014-05-19 12:54 ` [tip:sched/arch] metag: Remove TIF_POLLING_NRFLAG tip-bot for James Hogan
2014-05-22 12:26 ` [tip:sched/core] " tip-bot for James Hogan
2014-04-11 13:42 ` [RFC][PATCH 7/8] sched,idle: Delay clearing the polling bit Peter Zijlstra
2014-04-13 21:51 ` Nicolas Pitre
2014-04-11 13:42 ` [RFC][PATCH 8/8] sched,idle: Reflow cpuidle_idle_call() Peter Zijlstra
2014-04-13 21:36 ` Nicolas Pitre
2014-04-14 8:59 ` Peter Zijlstra
2014-04-14 9:25 ` Peter Zijlstra
2014-04-14 13:55 ` Nicolas Pitre
2014-04-11 15:00 ` [RFC][PATCH 0/8] sched,idle: need resched polling rework Andy Lutomirski
2014-04-11 15:14 ` Peter Zijlstra
2014-05-22 12:58 ` Peter Zijlstra
2014-05-22 13:09 ` Peter Zijlstra
2014-05-29 0:01 ` Andy Lutomirski
2014-05-29 6:48 ` Peter Zijlstra
2014-06-03 6:40 ` Andy Lutomirski
2014-06-03 6:51 ` Peter Zijlstra
2014-06-03 10:43 ` Peter Zijlstra
2014-06-03 14:02 ` Peter Zijlstra
2014-06-03 16:05 ` Andy Lutomirski
2014-06-03 16:19 ` Peter Zijlstra
2014-06-03 16:52 ` Andy Lutomirski
2014-06-03 17:00 ` Peter Zijlstra
2014-06-03 18:28 ` Peter Zijlstra [this message]
2014-06-03 18:44 ` Andy Lutomirski
2014-06-03 20:07 ` Andy Lutomirski
2014-04-12 8:35 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603182850.GJ16155@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=tglx@linutronix.de \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome