From: Peter Zijlstra <peterz@infradead.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/1] kernel/locking/rtmutex-tester.c: kernel-doc warning fix
Date: Fri, 6 Jun 2014 10:23:23 +0200 [thread overview]
Message-ID: <20140606082323.GV6758@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1401992965-11256-1-git-send-email-fabf@skynet.be>
[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]
On Thu, Jun 05, 2014 at 08:29:25PM +0200, Fabian Frederick wrote:
> attr was added by commit
> 4a0b2b4dbe1335
> ("sysdev: Pass the attribute to the low level sysdev show/store function")
>
> and is unused here.
I think tglx has a patch killing this entire file somewhere..
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> kernel/locking/rtmutex-tester.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/locking/rtmutex-tester.c b/kernel/locking/rtmutex-tester.c
> index 1d96dd0..abdc7d1 100644
> --- a/kernel/locking/rtmutex-tester.c
> +++ b/kernel/locking/rtmutex-tester.c
> @@ -266,6 +266,7 @@ static int test_func(void *data)
> /**
> * sysfs_test_command - interface for test commands
> * @dev: thread reference
> + * @attr: unused
> * @buf: command for actual step
> * @count: length of buffer
> *
> @@ -334,6 +335,7 @@ static ssize_t sysfs_test_command(struct device *dev, struct device_attribute *a
> /**
> * sysfs_test_status - sysfs interface for rt tester
> * @dev: thread to query
> + * @attr: unused
> * @buf: char buffer to be filled with thread status info
> */
> static ssize_t sysfs_test_status(struct device *dev, struct device_attribute *attr,
> --
> 1.8.4.5
>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-06-06 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 18:29 Fabian Frederick
2014-06-06 8:23 ` Peter Zijlstra [this message]
2014-06-06 20:54 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606082323.GV6758@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome