[PATCH 1/1] kernel/locking/rtmutex-tester.c: kernel-doc warning fix

[PATCH 1/1] kernel/locking/rtmutex-tester.c: kernel-doc warning fix

[Fabian Frederick]

attr was added by commit
4a0b2b4dbe1335
("sysdev: Pass the attribute to the low level sysdev show/store function")

and is unused here.

Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 kernel/locking/rtmutex-tester.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/locking/rtmutex-tester.c b/kernel/locking/rtmutex-tester.c
index 1d96dd0..abdc7d1 100644
--- a/kernel/locking/rtmutex-tester.c
+++ b/kernel/locking/rtmutex-tester.c
@@ -266,6 +266,7 @@ static int test_func(void *data)
 /**
  * sysfs_test_command - interface for test commands
  * @dev:	thread reference
+ * @attr:	unused
  * @buf:	command for actual step
  * @count:	length of buffer
  *
@@ -334,6 +335,7 @@ static ssize_t sysfs_test_command(struct device *dev, struct device_attribute *a
 /**
  * sysfs_test_status - sysfs interface for rt tester
  * @dev:	thread to query
+ * @attr:	unused
  * @buf:	char buffer to be filled with thread status info
  */
 static ssize_t sysfs_test_status(struct device *dev, struct device_attribute *attr,
-- 
1.8.4.5

Re: [PATCH 1/1] kernel/locking/rtmutex-tester.c: kernel-doc warning fix

[Peter Zijlstra]

[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]

On Thu, Jun 05, 2014 at 08:29:25PM +0200, Fabian Frederick wrote:
> attr was added by commit
> 4a0b2b4dbe1335
> ("sysdev: Pass the attribute to the low level sysdev show/store function")
> 
> and is unused here.

I think tglx has a patch killing this entire file somewhere..

> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>  kernel/locking/rtmutex-tester.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/locking/rtmutex-tester.c b/kernel/locking/rtmutex-tester.c
> index 1d96dd0..abdc7d1 100644
> --- a/kernel/locking/rtmutex-tester.c
> +++ b/kernel/locking/rtmutex-tester.c
> @@ -266,6 +266,7 @@ static int test_func(void *data)
>  /**
>   * sysfs_test_command - interface for test commands
>   * @dev:	thread reference
> + * @attr:	unused
>   * @buf:	command for actual step
>   * @count:	length of buffer
>   *
> @@ -334,6 +335,7 @@ static ssize_t sysfs_test_command(struct device *dev, struct device_attribute *a
>  /**
>   * sysfs_test_status - sysfs interface for rt tester
>   * @dev:	thread to query
> + * @attr:	unused
>   * @buf:	char buffer to be filled with thread status info
>   */
>  static ssize_t sysfs_test_status(struct device *dev, struct device_attribute *attr,
> -- 
> 1.8.4.5
> 

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 1/1] kernel/locking/rtmutex-tester.c: kernel-doc warning fix

[Thomas Gleixner]

On Fri, 6 Jun 2014, Peter Zijlstra wrote:

> On Thu, Jun 05, 2014 at 08:29:25PM +0200, Fabian Frederick wrote:
> > attr was added by commit
> > 4a0b2b4dbe1335
> > ("sysdev: Pass the attribute to the low level sysdev show/store function")
> > 
> > and is unused here.
> 
> I think tglx has a patch killing this entire file somewhere..

Yes, it's on hold due to the more important issues in that area, but
that file will be gone soon.

Though I need to come up with something more intelligent as a
replacement to unit test all the corner cases we discovered in the
last weeks ....

Thanks,

	tglx