From: "J. Bruce Fields" <bfields@fieldses.org>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: relative objtree change broke tar builds?
Date: Wed, 18 Jun 2014 09:14:52 -0400 [thread overview]
Message-ID: <20140618131452.GB17790@fieldses.org> (raw)
In-Reply-To: <53A18712.6030907@suse.cz>
On Wed, Jun 18, 2014 at 02:33:22PM +0200, Michal Marek wrote:
> Dne 18.6.2014 14:20, J. Bruce Fields napsal(a):
> > On Wed, Jun 18, 2014 at 11:06:12AM +0200, Michal Marek wrote:
> >> Dne 18.6.2014 00:38, J. Bruce Fields napsal(a):
> >>> The changelog there says
> >>>
> >>> The main Makefile sets its working directory to the object tree
> >>> and never changes it again. Therefore, we can use '.' instead of
> >>> the absolute path.
> >>>
> >>> But the main Makefile also exports objtree, and a quick grep suggests
> >>> lots of other uses outside the main Makefile.
> >>
> >> Do you have examples? Besides your report, I'm only aware of make
> >> deb-pkg and make *docs. What else?
> >
> > I haven't looked.
> >
> > I only note that grep finds 47 files referencing that variable, and
> > absent some argument that the remaining ones are correct, I'd be
> > inclined to revert.
>
> Do these 47 files change the working directory before referencing the
> variable?
Sorry, I'm not volunteering to check.
Note also that other variables are defined in terms of objtree, and they
may be exported or passed to other scripts.
--b.
next prev parent reply other threads:[~2014-06-18 13:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 22:38 J. Bruce Fields
2014-06-18 9:06 ` Michal Marek
2014-06-18 12:20 ` J. Bruce Fields
2014-06-18 12:33 ` Michal Marek
2014-06-18 13:14 ` J. Bruce Fields [this message]
2014-06-18 15:58 ` Randy Dunlap
2014-06-18 19:47 ` Michal Marek
2014-06-18 19:52 ` Sam Ravnborg
2014-06-18 21:13 ` Randy Dunlap
2014-07-04 21:37 ` Michal Marek
2014-07-04 21:40 ` Randy Dunlap
2014-07-07 1:04 ` Randy Dunlap
2014-06-18 21:20 ` Randy Dunlap
2014-06-19 1:21 ` Ken Moffat
2014-07-04 21:42 ` Michal Marek
2014-06-18 14:26 ` [PATCH] kbuild: Fix tar-pkg with relative $(objtree) Michal Marek
2014-06-18 15:29 ` J. Bruce Fields
2014-06-18 15:34 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618131452.GB17790@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®