From: Steven Rostedt <rostedt@goodmis.org>
To: Mike Galbraith <umgwanakikbuti@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [ANNOUNCE] 3.12.22-rt33
Date: Thu, 19 Jun 2014 09:44:16 -0400 [thread overview]
Message-ID: <20140619094416.302f5ef3@gandalf.local.home> (raw)
In-Reply-To: <1403149603.5189.10.camel@marge.simpson.net>
On Thu, 19 Jun 2014 05:46:43 +0200
Mike Galbraith <umgwanakikbuti@gmail.com> wrote:
> On Wed, 2014-06-18 at 20:12 -0400, Steven Rostedt wrote:
> > Dear RT Folks,
> >
> > I'm pleased to announce the 3.12.22-rt33 stable release.
Didn't we have this issue before?
>
>
> git@marge:~/linux-2.6> git diff v3.12... drivers/net/ethernet/dec/tulip/tulip_core.c
> diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
> index 4e8cfa2ac803..a6d4653ebbc3 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip_core.c
> +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
> @@ -1939,7 +1939,9 @@ static void tulip_remove_one(struct pci_dev *pdev)
> pci_iounmap(pdev, tp->base_addr);
> free_netdev (dev);
> pci_release_regions (pdev);
> + pci_disable_device(pdev);
> pci_set_drvdata (pdev, NULL);
> + pci_disable_device(pdev);
>
> /* pci_power_off (pdev, -1); */
> }
>
> commit 4a77edc195f0b03644e84dda00fcfe9827868e8e
> Author: Ingo Molnar <mingo@elte.hu>
> Date: Fri Jul 3 08:30:18 2009 -0500
>
> drivers/net: tulip_remove_one needs to call pci_disable_device()
>
> Otherwise the device is not completely shut down.
Grumble, this was a fix that went into -rt without going into stable
first.
OK, I'll remove this commit and keep the stable one.
Thanks!
-- Steve
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
> diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
> index 4e8cfa2ac803..7565b994ec50 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip_core.c
> +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
> @@ -1939,6 +1939,7 @@ static void tulip_remove_one(struct pci_dev *pdev)
> pci_iounmap(pdev, tp->base_addr);
> free_netdev (dev);
> pci_release_regions (pdev);
> + pci_disable_device(pdev);
> pci_set_drvdata (pdev, NULL);
>
> /* pci_power_off (pdev, -1); */
>
>
> commit 831bb5573dcbeb0da783c82e21084ac191dafc24
> Author: Ingo Molnar <mingo@elte.hu>
> Date: Fri Feb 14 15:32:20 2014 +0100
>
> drivers/net: tulip_remove_one needs to call pci_disable_device()
>
> commit c321f7d7c87cdc623c87845f6378620573e57512 upstream.
>
> Otherwise the device is not completely shut down.
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>
> diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
> index 4e8cfa2ac803..779016068a82 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip_core.c
> +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
> @@ -1940,6 +1940,7 @@ static void tulip_remove_one(struct pci_dev *pdev)
> free_netdev (dev);
> pci_release_regions (pdev);
> pci_set_drvdata (pdev, NULL);
> + pci_disable_device(pdev);
>
> /* pci_power_off (pdev, -1); */
> }
>
next prev parent reply other threads:[~2014-06-19 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 0:12 Steven Rostedt
2014-06-19 3:46 ` Mike Galbraith
2014-06-19 13:44 ` Steven Rostedt [this message]
2014-06-20 8:03 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619094416.302f5ef3@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=C.Emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®