* [PATCH] workqueue: remove useless WARN_ON_ONCE()
@ 2014-06-03 7:32 Lai Jiangshan
2014-06-19 16:28 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Lai Jiangshan @ 2014-06-03 7:32 UTC (permalink / raw)
To: linux-kernel; +Cc: Tejun Heo, Lai Jiangshan
The @cpu is fetched via smp_processor_id() in this function,
so the check is useless.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
kernel/workqueue.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 6b6e9f2..7dc6e66 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -4461,8 +4461,6 @@ static void wq_unbind_fn(struct work_struct *work)
struct worker *worker;
for_each_cpu_worker_pool(pool, cpu) {
- WARN_ON_ONCE(cpu != smp_processor_id());
-
mutex_lock(&pool->attach_mutex);
spin_lock_irq(&pool->lock);
--
1.7.4.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] workqueue: remove useless WARN_ON_ONCE()
2014-06-03 7:32 [PATCH] workqueue: remove useless WARN_ON_ONCE() Lai Jiangshan
@ 2014-06-19 16:28 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2014-06-19 16:28 UTC (permalink / raw)
To: Lai Jiangshan; +Cc: linux-kernel
On Tue, Jun 03, 2014 at 03:32:41PM +0800, Lai Jiangshan wrote:
> The @cpu is fetched via smp_processor_id() in this function,
> so the check is useless.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Applied to wq/for-3.17.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-19 16:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-03 7:32 [PATCH] workqueue: remove useless WARN_ON_ONCE() Lai Jiangshan
2014-06-19 16:28 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®