[PATCH] w1: select crc16 library for ds2406

[PATCH] w1: select crc16 library for ds2406

[Arnd Bergmann]

commit 94859308a21b "w1: new w1_ds2406 driver" added a new driver
that uses the crc16 library, but didn't ensure that the core is
there. This adds the necessary Kconfig statements, just like we
have it for other w1 drivers.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Scott Alfter <scott@alfter.us>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/w1/slaves/Kconfig b/drivers/w1/slaves/Kconfig
index fd31d2f..cfe74d0 100644
--- a/drivers/w1/slaves/Kconfig
+++ b/drivers/w1/slaves/Kconfig
@@ -40,6 +40,7 @@ config W1_SLAVE_DS2413
 
 config W1_SLAVE_DS2406
 	tristate "Dual Channel Addressable Switch 0x12 family support (DS2406)"
+	select CRC16
 	help
 	  Say Y or M here if you want to use a 1-wire
 	  DS2406 Dual Channel Addressable Switch.  EPROM read/write

Re: [PATCH] w1: select crc16 library for ds2406

[Scott Alfter]

On Mon, June 23, 2014 14:31, Arnd Bergmann wrote:
> commit 94859308a21b "w1: new w1_ds2406 driver" added a new driver
> that uses the crc16 library, but didn't ensure that the core is
> there. This adds the necessary Kconfig statements, just like we
> have it for other w1 drivers.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Scott Alfter <scott@alfter.us>
> Cc: Evgeniy Polyakov <zbr@ioremap.net>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Sounds OK to me...was an oversight on my part. Do I need to put together
another patchfile, or can this one be combined with the one I've already
sent in? As an alternative, it's in my kernel tree at
https://github.com/salfter/adafruit-raspberrypi-linux.

Scott Alfter
scott@alfter.us

Re: [PATCH] w1: select crc16 library for ds2406

[Greg Kroah-Hartman]

On Mon, Jun 23, 2014 at 04:19:58PM -0000, Scott Alfter wrote:
> On Mon, June 23, 2014 14:31, Arnd Bergmann wrote:
> > commit 94859308a21b "w1: new w1_ds2406 driver" added a new driver
> > that uses the crc16 library, but didn't ensure that the core is
> > there. This adds the necessary Kconfig statements, just like we
> > have it for other w1 drivers.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: Scott Alfter <scott@alfter.us>
> > Cc: Evgeniy Polyakov <zbr@ioremap.net>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Sounds OK to me...was an oversight on my part. Do I need to put together
> another patchfile, or can this one be combined with the one I've already
> sent in? As an alternative, it's in my kernel tree at
> https://github.com/salfter/adafruit-raspberrypi-linux.

I'll take it as-is, I can't do anything with some random github tree :)

thanks,

greg k-h