From: Mateusz Guzik <mguzik@redhat.com>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: lib/argv_split.c : should argv be kfree'ed ?
Date: Sun, 29 Jun 2014 00:04:21 +0200 [thread overview]
Message-ID: <20140628220421.GA24883@mguzik.redhat.com> (raw)
In-Reply-To: <53AF3925.7070300@gmx.de>
On Sat, Jun 28, 2014 at 11:52:37PM +0200, Toralf Förster wrote:
> /me wonders if this patch is needed here :
>
>
> diff --git a/lib/argv_split.c b/lib/argv_split.c
> index e927ed0..7de4cb4 100644
> --- a/lib/argv_split.c
> +++ b/lib/argv_split.c
> @@ -85,6 +85,7 @@ char **argv_split(gfp_t gfp, const char *str, int *argcp)
> *argv++ = argv_str;
> }
> }
> + kfree (argv);
> *argv = NULL;
>
> if (argcp)
>
No, see argv_free.
--
Mateusz Guzik
next prev parent reply other threads:[~2014-06-28 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 21:52 Toralf Förster
2014-06-28 22:04 ` Mateusz Guzik [this message]
2014-06-29 14:40 ` Toralf Förster
2014-06-29 15:37 ` Mateusz Guzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140628220421.GA24883@mguzik.redhat.com \
--to=mguzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome