mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Toralf Förster" <toralf.foerster@gmx.de>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: lib/argv_split.c : should argv be kfree'ed ?
Date: Sat, 28 Jun 2014 23:52:37 +0200	[thread overview]
Message-ID: <53AF3925.7070300@gmx.de> (raw)

/me wonders if this patch is needed here :


diff --git a/lib/argv_split.c b/lib/argv_split.c
index e927ed0..7de4cb4 100644
--- a/lib/argv_split.c
+++ b/lib/argv_split.c
@@ -85,6 +85,7 @@ char **argv_split(gfp_t gfp, const char *str, int *argcp)
                        *argv++ = argv_str;
                }
        }
+       kfree (argv);
        *argv = NULL;

        if (argcp)

-- 
Toralf


             reply	other threads:[~2014-06-28 21:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-28 21:52 Toralf Förster [this message]
2014-06-28 22:04 ` Mateusz Guzik
2014-06-29 14:40   ` Toralf Förster
2014-06-29 15:37     ` Mateusz Guzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AF3925.7070300@gmx.de \
    --to=toralf.foerster@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome