From: Alexey Dobriyan <adobriyan@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] headers: remove fs.h from poll.h
Date: Wed, 2 Jul 2014 01:06:42 +0300 [thread overview]
Message-ID: <20140701220642.GA3150@p183.telecom.by> (raw)
In-Reply-To: <20140701134338.1d221dd127ffef4c25e86800@linux-foundation.org>
On Tue, Jul 01, 2014 at 01:43:38PM -0700, Andrew Morton wrote:
> On Tue, 1 Jul 2014 23:01:50 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> > fs.h is new sched.h!
> >
> > Start removing unnecessary fs.h inclusions.
> >
> > In the end of the whole series ~2000 useless fs.h inclusions are gone
> > (just need more comple testing).
> >
>
> This changelog is rather confusing.
>
> The patch adds lots *more* fs.h inclusions. I *think* the intent is to
> remove one nested inclusion in poll.h. But that contradicts your third
> paragraph.
>
> Help us out here, OK?
fs.h inclusion is unnecessary because it is only needed
for "struct file" forward declaration.
Those fs.h inclusions are fixing inevitable compilation failures.
There maybe more compilation failures.
What I did to get 2000 number is:
* make allmodconfig
* make
* touch include/linux/fs.h
* make
* [count how many files were rebuilt]
After more header tweaking the number of files that were rebuilt dropped
by ~2000 but code still compiles, which means fs.h inclusions were useless.
This is first patch in series. Same thing we did with sched.h earlier.
Alexey
next prev parent reply other threads:[~2014-07-01 22:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 20:01 Alexey Dobriyan
2014-07-01 20:43 ` Andrew Morton
2014-07-01 22:06 ` Alexey Dobriyan [this message]
2014-07-02 23:09 ` David Rientjes
2014-07-05 9:07 ` Alexey Dobriyan
2014-07-30 1:20 ` David Rientjes
2014-08-04 19:53 ` David Rientjes
2014-08-16 23:37 Alexey Dobriyan
[not found] ` <CA+55aFw3B=USNMLdehm+hv9fVWE1yaR42a2y8udcE8QvJfbSPA@mail.gmail.com>
2014-08-17 9:33 ` Alexey Dobriyan
2014-08-17 22:45 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701220642.GA3150@p183.telecom.by \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®