mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] headers: remove fs.h from poll.h
Date: Wed, 2 Jul 2014 16:09:17 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.02.1407021605490.5931@chino.kir.corp.google.com> (raw)
In-Reply-To: <20140701220642.GA3150@p183.telecom.by>

On Wed, 2 Jul 2014, Alexey Dobriyan wrote:

> fs.h inclusion is unnecessary because it is only needed
> for "struct file" forward declaration.
> 
> Those fs.h inclusions are fixing inevitable compilation failures.
> There maybe more compilation failures.
> 
> What I did to get 2000 number is:
> * make allmodconfig
> * make
> * touch include/linux/fs.h
> * make
> * [count how many files were rebuilt]
> 
> After more header tweaking the number of files that were rebuilt dropped
> by ~2000 but code still compiles, which means fs.h inclusions were useless.
> 

Lots of #ifdefs in fs.h, I hope your series includes building for all 
possible combinations.

> This is first patch in series. Same thing we did with sched.h earlier.
> 

Is it possible to post the whole series together so it makes sense and 
it's possible to put it through some thorough build testing?  If you can 
point me to a git tree that I can pull, then I can do that on 
infrastructure that I have probably quicker than most.

  reply	other threads:[~2014-07-02 23:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01 20:01 Alexey Dobriyan
2014-07-01 20:43 ` Andrew Morton
2014-07-01 22:06   ` Alexey Dobriyan
2014-07-02 23:09     ` David Rientjes [this message]
2014-07-05  9:07       ` Alexey Dobriyan
2014-07-30  1:20         ` David Rientjes
2014-08-04 19:53           ` David Rientjes
2014-08-16 23:37 Alexey Dobriyan
     [not found] ` <CA+55aFw3B=USNMLdehm+hv9fVWE1yaR42a2y8udcE8QvJfbSPA@mail.gmail.com>
2014-08-17  9:33   ` Alexey Dobriyan
2014-08-17 22:45     ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1407021605490.5931@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®