[PATCH] fix reregistering of serial console

[PATCH] fix reregistering of serial console

[Waldemar Brodkorb]

Runtime tested on Mikrotik RB532 board.
Thanks goes to Geert Uytterhoeven for the explanation of the problem.

"I'm afraid this is not gonna help. When the port is unregistered,
its type will be reset to PORT_UNKNOWN.
So before registering it again, its type must be set again the actual
serial driver, cfr. the change to of_serial.c."

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 arch/mips/rb532/devices.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/rb532/devices.c b/arch/mips/rb532/devices.c
index 3af00b2..ba61268 100644
--- a/arch/mips/rb532/devices.c
+++ b/arch/mips/rb532/devices.c
@@ -223,6 +223,7 @@ static struct platform_device rb532_wdt = {
 
 static struct plat_serial8250_port rb532_uart_res[] = {
 	{
+		.type           = PORT_16550A,
 		.membase	= (char *)KSEG1ADDR(REGBASE + UART0BASE),
 		.irq		= UART0_IRQ,
 		.regshift	= 2,
-- 
1.7.10.4

Re: [PATCH] fix reregistering of serial console

[Florian Fainelli]

2014-07-02 9:09 GMT-07:00 Waldemar Brodkorb <wbx@openadk.org>:
> Runtime tested on Mikrotik RB532 board.
> Thanks goes to Geert Uytterhoeven for the explanation of the problem.

The subject should be something like "MIPS: rb532: fix reregistering
of serial console" to be consistent with the other changes.

>
> "I'm afraid this is not gonna help. When the port is unregistered,
> its type will be reset to PORT_UNKNOWN.
> So before registering it again, its type must be set again the actual
> serial driver, cfr. the change to of_serial.c."
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

Reviewed-by: Florian Fainelli <florian@openwrt.org>

Thanks!

> ---
>  arch/mips/rb532/devices.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/rb532/devices.c b/arch/mips/rb532/devices.c
> index 3af00b2..ba61268 100644
> --- a/arch/mips/rb532/devices.c
> +++ b/arch/mips/rb532/devices.c
> @@ -223,6 +223,7 @@ static struct platform_device rb532_wdt = {
>
>  static struct plat_serial8250_port rb532_uart_res[] = {
>         {
> +               .type           = PORT_16550A,
>                 .membase        = (char *)KSEG1ADDR(REGBASE + UART0BASE),
>                 .irq            = UART0_IRQ,
>                 .regshift       = 2,
> --
> 1.7.10.4
>
>



-- 
Florian