* Re: question about drivers/spi/spi-au1550.c
[not found] <CAB78YHy2tW4u5rrsz9yKqpD7uigtkp=B4Z950323-v0vGk5R8g@mail.gmail.com>
@ 2014-07-02 19:44 ` Mark Brown
0 siblings, 0 replies; only message in thread
From: Mark Brown @ 2014-07-02 19:44 UTC (permalink / raw)
To: Himangi Saraogi; +Cc: linux-spi, linux-kernel, Julia Lawall
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
On Thu, Jul 03, 2014 at 12:31:45AM +0530, Himangi Saraogi wrote:
> I find in the probe function that hw->ioarea is allocated using
> request_mem_region but a release_resource and kfree is called on it instead
> of a release_mem_region. Is there any special concern behind this. I was
> planning to use devm_ioremap_resource here.
I'd expect this is just a bug you've spotted. If you could send two
patches, one fixing the bug and the other doing the devm_ conversion,
that'd be ideal but a single patch is also fine.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-07-02 19:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAB78YHy2tW4u5rrsz9yKqpD7uigtkp=B4Z950323-v0vGk5R8g@mail.gmail.com>
2014-07-02 19:44 ` question about drivers/spi/spi-au1550.c Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®