mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sam Asadi <asadi.samuel@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: comedi: adv_pci1710.c line over 80 fixed
Date: Sat, 19 Jul 2014 21:09:49 -0700	[thread overview]
Message-ID: <20140720040949.GB5875@kroah.com> (raw)
In-Reply-To: <1405818950-9858-1-git-send-email-asadi.samuel@gmail.com>

On Sun, Jul 20, 2014 at 04:15:50AM +0300, Sam Asadi wrote:
> A line over 80 issue fixed, which is a comment.
> 
> Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
> ---
>  drivers/staging/comedi/drivers/adv_pci1710.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/drivers/staging/comedi/drivers/adv_pci1710.c
> index 602b7a1..13ff78c 100644
> --- a/drivers/staging/comedi/drivers/adv_pci1710.c
> +++ b/drivers/staging/comedi/drivers/adv_pci1710.c
> @@ -723,7 +723,8 @@ static int pci171x_ai_cancel(struct comedi_device *dev,
>  		devpriv->CntrlReg &= Control_CNT0;
>  		devpriv->CntrlReg |= Control_SW;
>  
> -		outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL);	/*  reset any operations */
> +		outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL);
> +						/* reset any operations */

That really doesn't make any sense now, does it?

Please put it _before_ the outw() call.

thanks,

greg k-h

      reply	other threads:[~2014-07-20  4:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-20  1:15 Sam Asadi
2014-07-20  4:09 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140720040949.GB5875@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=asadi.samuel@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®