* [PATCH 2/2] Staging: comedi: adv_pci1710.c line over 80 fixed
@ 2014-07-20 1:15 Sam Asadi
2014-07-20 4:09 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Sam Asadi @ 2014-07-20 1:15 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Sam Asadi
A line over 80 issue fixed, which is a comment.
Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
---
drivers/staging/comedi/drivers/adv_pci1710.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/drivers/staging/comedi/drivers/adv_pci1710.c
index 602b7a1..13ff78c 100644
--- a/drivers/staging/comedi/drivers/adv_pci1710.c
+++ b/drivers/staging/comedi/drivers/adv_pci1710.c
@@ -723,7 +723,8 @@ static int pci171x_ai_cancel(struct comedi_device *dev,
devpriv->CntrlReg &= Control_CNT0;
devpriv->CntrlReg |= Control_SW;
- outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL); /* reset any operations */
+ outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL);
+ /* reset any operations */
pci171x_start_pacer(dev, false);
outb(0, dev->iobase + PCI171x_CLRFIFO);
outb(0, dev->iobase + PCI171x_CLRINT);
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] Staging: comedi: adv_pci1710.c line over 80 fixed
2014-07-20 1:15 [PATCH 2/2] Staging: comedi: adv_pci1710.c line over 80 fixed Sam Asadi
@ 2014-07-20 4:09 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-07-20 4:09 UTC (permalink / raw)
To: Sam Asadi; +Cc: devel, linux-kernel
On Sun, Jul 20, 2014 at 04:15:50AM +0300, Sam Asadi wrote:
> A line over 80 issue fixed, which is a comment.
>
> Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
> ---
> drivers/staging/comedi/drivers/adv_pci1710.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/drivers/staging/comedi/drivers/adv_pci1710.c
> index 602b7a1..13ff78c 100644
> --- a/drivers/staging/comedi/drivers/adv_pci1710.c
> +++ b/drivers/staging/comedi/drivers/adv_pci1710.c
> @@ -723,7 +723,8 @@ static int pci171x_ai_cancel(struct comedi_device *dev,
> devpriv->CntrlReg &= Control_CNT0;
> devpriv->CntrlReg |= Control_SW;
>
> - outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL); /* reset any operations */
> + outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL);
> + /* reset any operations */
That really doesn't make any sense now, does it?
Please put it _before_ the outw() call.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-20 4:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-20 1:15 [PATCH 2/2] Staging: comedi: adv_pci1710.c line over 80 fixed Sam Asadi
2014-07-20 4:09 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®