* [PATCH] ceph: convert comma to semicolon
@ 2014-07-23 14:41 Himangi Saraogi
2014-07-24 8:09 ` Ilya Dryomov
0 siblings, 1 reply; 5+ messages in thread
From: Himangi Saraogi @ 2014-07-23 14:41 UTC (permalink / raw)
To: Sage Weil, ceph-devel, linux-kernel; +Cc: julia.lawall
Replace a comma between expression statements by a semicolon. This changes
the semantics of the code, but given the current indentation appears to be
what is intended.
A simplified version of the Coccinelle semantic patch that performs this
transformation is as follows:
// <smpl>
@r@
expression e1,e2;
@@
e1
-,
+;
e2;
// </smpl>
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
fs/ceph/caps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
index 1fde164..6d1cd45 100644
--- a/fs/ceph/caps.c
+++ b/fs/ceph/caps.c
@@ -3277,7 +3277,7 @@ int ceph_encode_inode_release(void **p, struct inode *inode,
rel->ino = cpu_to_le64(ceph_ino(inode));
rel->cap_id = cpu_to_le64(cap->cap_id);
rel->seq = cpu_to_le32(cap->seq);
- rel->issue_seq = cpu_to_le32(cap->issue_seq),
+ rel->issue_seq = cpu_to_le32(cap->issue_seq);
rel->mseq = cpu_to_le32(cap->mseq);
rel->caps = cpu_to_le32(cap->implemented);
rel->wanted = cpu_to_le32(cap->mds_wanted);
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ceph: convert comma to semicolon
2014-07-23 14:41 [PATCH] ceph: convert comma to semicolon Himangi Saraogi
@ 2014-07-24 8:09 ` Ilya Dryomov
0 siblings, 0 replies; 5+ messages in thread
From: Ilya Dryomov @ 2014-07-24 8:09 UTC (permalink / raw)
To: Himangi Saraogi
Cc: Sage Weil, Ceph Development, Linux Kernel Mailing List, Julia Lawall
On Wed, Jul 23, 2014 at 6:41 PM, Himangi Saraogi <himangi774@gmail.com> wrote:
> Replace a comma between expression statements by a semicolon. This changes
> the semantics of the code, but given the current indentation appears to be
> what is intended.
>
> A simplified version of the Coccinelle semantic patch that performs this
> transformation is as follows:
> // <smpl>
> @r@
> expression e1,e2;
> @@
>
> e1
> -,
> +;
> e2;
> // </smpl>
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Applied.
Thanks,
Ilya
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ceph: convert comma to semicolon
2024-07-10 7:18 ` Xiubo Li
@ 2024-07-10 8:17 ` Ilya Dryomov
0 siblings, 0 replies; 5+ messages in thread
From: Ilya Dryomov @ 2024-07-10 8:17 UTC (permalink / raw)
To: Xiubo Li; +Cc: Chen Ni, ceph-devel, linux-kernel
On Wed, Jul 10, 2024 at 9:18 AM Xiubo Li <xiubli@redhat.com> wrote:
>
>
> On 7/9/24 14:44, Chen Ni wrote:
> > Replace a comma between expression statements by a semicolon.
> >
> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> > ---
> > fs/ceph/dir.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c
> > index 5aadc56e0cc0..18c72b305858 100644
> > --- a/fs/ceph/dir.c
> > +++ b/fs/ceph/dir.c
> > @@ -1589,7 +1589,7 @@ void __ceph_dentry_dir_lease_touch(struct ceph_dentry_info *di)
> > }
> >
> > spin_lock(&mdsc->dentry_list_lock);
> > - __dentry_dir_lease_touch(mdsc, di),
> > + __dentry_dir_lease_touch(mdsc, di);
> > spin_unlock(&mdsc->dentry_list_lock);
> > }
> >
> Reviewed-by: Xiubo Li <xiubli@redhat.com>
Applied.
Thanks,
Ilya
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ceph: convert comma to semicolon
2024-07-09 6:44 Chen Ni
@ 2024-07-10 7:18 ` Xiubo Li
2024-07-10 8:17 ` Ilya Dryomov
0 siblings, 1 reply; 5+ messages in thread
From: Xiubo Li @ 2024-07-10 7:18 UTC (permalink / raw)
To: Chen Ni, idryomov; +Cc: ceph-devel, linux-kernel
On 7/9/24 14:44, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> fs/ceph/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c
> index 5aadc56e0cc0..18c72b305858 100644
> --- a/fs/ceph/dir.c
> +++ b/fs/ceph/dir.c
> @@ -1589,7 +1589,7 @@ void __ceph_dentry_dir_lease_touch(struct ceph_dentry_info *di)
> }
>
> spin_lock(&mdsc->dentry_list_lock);
> - __dentry_dir_lease_touch(mdsc, di),
> + __dentry_dir_lease_touch(mdsc, di);
> spin_unlock(&mdsc->dentry_list_lock);
> }
>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ceph: convert comma to semicolon
@ 2024-07-09 6:44 Chen Ni
2024-07-10 7:18 ` Xiubo Li
0 siblings, 1 reply; 5+ messages in thread
From: Chen Ni @ 2024-07-09 6:44 UTC (permalink / raw)
To: xiubli, idryomov; +Cc: ceph-devel, linux-kernel, Chen Ni
Replace a comma between expression statements by a semicolon.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
fs/ceph/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c
index 5aadc56e0cc0..18c72b305858 100644
--- a/fs/ceph/dir.c
+++ b/fs/ceph/dir.c
@@ -1589,7 +1589,7 @@ void __ceph_dentry_dir_lease_touch(struct ceph_dentry_info *di)
}
spin_lock(&mdsc->dentry_list_lock);
- __dentry_dir_lease_touch(mdsc, di),
+ __dentry_dir_lease_touch(mdsc, di);
spin_unlock(&mdsc->dentry_list_lock);
}
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-10 8:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-23 14:41 [PATCH] ceph: convert comma to semicolon Himangi Saraogi
2014-07-24 8:09 ` Ilya Dryomov
2024-07-09 6:44 Chen Ni
2024-07-10 7:18 ` Xiubo Li
2024-07-10 8:17 ` Ilya Dryomov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®