* [PATCH] ASoC: ak4642: Make of_device_id array const
@ 2014-07-24 11:58 Kiran Padwal
2014-07-25 16:41 ` Mark Brown
2014-07-25 17:21 ` Mark Brown
0 siblings, 2 replies; 6+ messages in thread
From: Kiran Padwal @ 2014-07-24 11:58 UTC (permalink / raw)
To: lgirdwood, broonie
Cc: perex, tiwai, s.hauer, fabio.estevam, kuninori.morimoto.gx,
Li.Xiubo, kiran.padwal21, alsa-devel, linux-kernel
Make of_device_id array const, because all OF functions handle it as const
Signed-off-by: Kiran Padwal <kiran.padwal21@gmail.com>
---
sound/soc/codecs/ak4642.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/ak4642.c b/sound/soc/codecs/ak4642.c
index 3ba4c0f..4b2ae61 100644
--- a/sound/soc/codecs/ak4642.c
+++ b/sound/soc/codecs/ak4642.c
@@ -593,7 +593,7 @@ static int ak4642_i2c_remove(struct i2c_client *client)
return 0;
}
-static struct of_device_id ak4642_of_match[] = {
+static const struct of_device_id ak4642_of_match[] = {
{ .compatible = "asahi-kasei,ak4642", .data = &ak4642_drvdata},
{ .compatible = "asahi-kasei,ak4643", .data = &ak4643_drvdata},
{ .compatible = "asahi-kasei,ak4648", .data = &ak4648_drvdata},
--
1.7.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ASoC: ak4642: Make of_device_id array const
2014-07-24 11:58 [PATCH] ASoC: ak4642: Make of_device_id array const Kiran Padwal
@ 2014-07-25 16:41 ` Mark Brown
2014-07-25 17:21 ` Mark Brown
1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2014-07-25 16:41 UTC (permalink / raw)
To: Kiran Padwal
Cc: lgirdwood, perex, tiwai, s.hauer, fabio.estevam,
kuninori.morimoto.gx, Li.Xiubo, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 157 bytes --]
On Thu, Jul 24, 2014 at 05:28:36PM +0530, Kiran Padwal wrote:
> Make of_device_id array const, because all OF functions handle it as const
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: ak4642: Make of_device_id array const
2014-07-24 11:58 [PATCH] ASoC: ak4642: Make of_device_id array const Kiran Padwal
2014-07-25 16:41 ` Mark Brown
@ 2014-07-25 17:21 ` Mark Brown
2014-07-26 7:53 ` kiran padwal
1 sibling, 1 reply; 6+ messages in thread
From: Mark Brown @ 2014-07-25 17:21 UTC (permalink / raw)
To: Kiran Padwal
Cc: lgirdwood, perex, tiwai, s.hauer, fabio.estevam,
kuninori.morimoto.gx, Li.Xiubo, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
On Thu, Jul 24, 2014 at 05:28:36PM +0530, Kiran Padwal wrote:
> Make of_device_id array const, because all OF functions handle it as const
...and reverted because it fails to build.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: ak4642: Make of_device_id array const
2014-07-25 17:21 ` Mark Brown
@ 2014-07-26 7:53 ` kiran padwal
0 siblings, 0 replies; 6+ messages in thread
From: kiran padwal @ 2014-07-26 7:53 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, perex, tiwai, s.hauer, fabio.estevam,
Kuninori Morimoto, Li.Xiubo, alsa-devel, linux-kernel
On Fri, Jul 25, 2014 at 10:51 PM, Mark Brown <broonie@kernel.org> wrote:
> On Thu, Jul 24, 2014 at 05:28:36PM +0530, Kiran Padwal wrote:
>> Make of_device_id array const, because all OF functions handle it as const
>
> ...and reverted because it fails to build.
sorry for that...I miss one thing...I will resubmit the patch.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ASoC: ak4642: Make of_device_id array const
@ 2014-07-28 6:11 Kiran Padwal
2014-07-28 21:29 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Kiran Padwal @ 2014-07-28 6:11 UTC (permalink / raw)
To: lgirdwood, broonie
Cc: perex, tiwai, s.hauer, fabio.estevam, kuninori.morimoto.gx,
Li.Xiubo, kiran.padwal21, alsa-devel, linux-kernel
Make of_device_id array const, because all OF functions handle it as const
Signed-off-by: Kiran Padwal <kiran.padwal21@gmail.com>
---
sound/soc/codecs/ak4642.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/ak4642.c b/sound/soc/codecs/ak4642.c
index 3ba4c0f..0417125 100644
--- a/sound/soc/codecs/ak4642.c
+++ b/sound/soc/codecs/ak4642.c
@@ -547,7 +547,7 @@ static const struct ak4642_drvdata ak4648_drvdata = {
.extended_frequencies = 1,
};
-static struct of_device_id ak4642_of_match[];
+static const struct of_device_id ak4642_of_match[];
static int ak4642_i2c_probe(struct i2c_client *i2c,
const struct i2c_device_id *id)
{
@@ -593,7 +593,7 @@ static int ak4642_i2c_remove(struct i2c_client *client)
return 0;
}
-static struct of_device_id ak4642_of_match[] = {
+static const struct of_device_id ak4642_of_match[] = {
{ .compatible = "asahi-kasei,ak4642", .data = &ak4642_drvdata},
{ .compatible = "asahi-kasei,ak4643", .data = &ak4643_drvdata},
{ .compatible = "asahi-kasei,ak4648", .data = &ak4648_drvdata},
--
1.7.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ASoC: ak4642: Make of_device_id array const
2014-07-28 6:11 Kiran Padwal
@ 2014-07-28 21:29 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2014-07-28 21:29 UTC (permalink / raw)
To: Kiran Padwal
Cc: lgirdwood, perex, tiwai, s.hauer, fabio.estevam,
kuninori.morimoto.gx, Li.Xiubo, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 157 bytes --]
On Mon, Jul 28, 2014 at 11:41:04AM +0530, Kiran Padwal wrote:
> Make of_device_id array const, because all OF functions handle it as const
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-28 21:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-24 11:58 [PATCH] ASoC: ak4642: Make of_device_id array const Kiran Padwal
2014-07-25 16:41 ` Mark Brown
2014-07-25 17:21 ` Mark Brown
2014-07-26 7:53 ` kiran padwal
2014-07-28 6:11 Kiran Padwal
2014-07-28 21:29 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®