mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "Greg KH" <gregkh@linuxfoundation.org>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Miguel Oliveira" <cmroliv@gmail.com>,
	gulsah.1004@gmail.com, peter.p.waskiewicz.jr@intel.com,
	kristina.martsenko@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: nokia_h4: merge firmware together so that we can reduce ammount of exports
Date: Sat, 9 Aug 2014 17:47:24 +0200	[thread overview]
Message-ID: <20140809154724.GA6771@amd.pavel.ucw.cz> (raw)
In-Reply-To: <FAB4A38E-6DFE-48FA-9D52-258DD77A39B6@holtmann.org>

Hi!


> > +
> > +	skb_queue_tail(&info->txq, fw_skb);
> > +	spin_lock_irqsave(&info->lock, flags);
> > +	hci_h4p_outb(info, UART_IER, hci_h4p_inb(info, UART_IER) |
> > +			UART_IER_THRI);
> > +	spin_unlock_irqrestore(&info->lock, flags);
> > +}
> 
> and as I explained before, this crazy can not continue. Bluetooth drivers can provide a hdev->setup callback for loading firmware and doing other setup details. You can just bring up the HCI transport. We are providing __hci_cmd_sync for easy loading of the firmware. Especially if the firmware just consists of HCI commands. Which is clearly the case with the Nokia firmware files.
> 

I know that this crazyness can not continue; but I need to be able to
move "bad" code around to get the cleanups, ok? Because you also asked
me to reduce ammount of exports.

Best regards,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2014-08-09 15:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-30 10:27 [PATCH] staging: nokia_h4: nokia_core.c: use usleep_range() instead of msleep() Miguel Oliveira
2014-05-30 11:34 ` Pavel Machek
2014-05-30 11:52   ` Marcel Holtmann
2014-05-30 12:30     ` Pavel Machek
2014-05-30 15:59       ` Greg KH
2014-05-30 16:15         ` Pali Rohár
2014-05-30 16:36           ` Greg KH
2014-08-06 20:56             ` Marcel Holtmann
2014-08-06 21:30               ` Pavel Machek
2014-08-07  0:25                 ` Greg KH
2014-08-07  8:13                   ` [PATCH] staging: nokia_h4: use more consistent name for intermediate object Pavel Machek
2014-08-07 20:24                     ` Greg KH
2014-08-09 15:48                       ` Pavel Machek
2014-08-10  7:29                       ` [PATCH 1/3] staging: nokia_h4: switch to right types and use bdaddr_t Pavel Machek
2014-08-10  7:31                       ` [PATCH 2/3] staging: nokia_h4: avoid __uX types Pavel Machek
2014-08-10  7:33                       ` [PATCH 3/3] staging: use inlines where it makes sense Pavel Machek
2014-08-10  7:34                       ` [PATCH] bluetooth: avoid using __uX types Pavel Machek
2014-08-07  9:07                   ` [PATCH] staging: nokia_h4: merge firmware together so that we can reduce ammount of exports Pavel Machek
2014-08-07  9:36                     ` Pavel Machek
2014-08-07 14:48                     ` Marcel Holtmann
2014-08-09 15:47                       ` Pavel Machek [this message]
2014-05-30 12:15   ` [PATCH] staging: nokia_h4: nokia_core.c: use usleep_range() instead of msleep() Miguel Oliveira
2014-05-30 12:35     ` Pavel Machek
2014-05-30 12:58       ` Miguel Oliveira
2014-05-30 16:01 ` Greg KH
2014-05-30 16:05   ` Miguel Oliveira
2014-05-30 16:13     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140809154724.GA6771@amd.pavel.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=cmroliv@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gulsah.1004@gmail.com \
    --cc=kristina.martsenko@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=pali.rohar@gmail.com \
    --cc=peter.p.waskiewicz.jr@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®