From: Mark Rutland <mark.rutland@arm.com>
To: Inha Song <ideal.song@samsung.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"patches@opensource.wolfsonmicro.com"
<patches@opensource.wolfsonmicro.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"ckeepax@opensource.wolfsonmicro.com"
<ckeepax@opensource.wolfsonmicro.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
Pawel Moll <Pawel.Moll@arm.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"cw00.choi@samsung.com" <cw00.choi@samsung.com>
Subject: Re: [alsa-devel] [PATCH 2/2] mfd: arizona: Update DT binding to support INn_MODE
Date: Mon, 11 Aug 2014 11:06:06 +0100 [thread overview]
Message-ID: <20140811100606.GB17745@leverpostej> (raw)
In-Reply-To: <20140809173545.2fc1f72e@songinha-Samsung-DeskTop-System>
On Sat, Aug 09, 2014 at 09:35:45AM +0100, Inha Song wrote:
> This patch update DT binding to support INn_MODE init_data
>
> Signed-off-by: Inha Song <ideal.song@samsung.com>
> ---
> Documentation/devicetree/bindings/mfd/arizona.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index 5c7e723..c21a30e 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -42,6 +42,11 @@ Optional properties:
> the chip default will be used. If present exactly five values must
> be specified.
>
> + - wlf,inmode : A list of INn_MODE register values. If absent, INn_MODE register
> + set to 0 by default. The size of this list depends on ARIZONA_MAX_INPUT values.
> + ARIZONA_MAX_INPUT is defined in include/linux/mfd/arizona/pdata.h. If present,
> + exactly ARIZONA_MAX_INPUT values must be specified.
Please don't refer to Linux internals here. How many INn_MODE registers
can this hardware have?
Why does this need to be overriden? Please mention this in the commit
message and documentation.
Why is exposing a raw register value the best way of doing this?
Thanks,
Mark.
prev parent reply other threads:[~2014-08-11 10:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-09 8:35 Inha Song
2014-08-11 10:06 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811100606.GB17745@leverpostej \
--to=mark.rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ideal.song@samsung.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®