* [alsa-devel] [PATCH 2/2] mfd: arizona: Update DT binding to support INn_MODE
@ 2014-08-09 8:35 Inha Song
2014-08-11 10:06 ` Mark Rutland
0 siblings, 1 reply; 2+ messages in thread
From: Inha Song @ 2014-08-09 8:35 UTC (permalink / raw)
To: broonie
Cc: alsa-devel, patches, linux-kernel, lee.jones, ckeepax, lgirdwood,
sameo, devicetree, galak, ijc+devicetree, mark.rutland,
pawel.moll, robh+dt, cw00.choi
This patch update DT binding to support INn_MODE init_data
Signed-off-by: Inha Song <ideal.song@samsung.com>
---
Documentation/devicetree/bindings/mfd/arizona.txt | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
index 5c7e723..c21a30e 100644
--- a/Documentation/devicetree/bindings/mfd/arizona.txt
+++ b/Documentation/devicetree/bindings/mfd/arizona.txt
@@ -42,6 +42,11 @@ Optional properties:
the chip default will be used. If present exactly five values must
be specified.
+ - wlf,inmode : A list of INn_MODE register values. If absent, INn_MODE register
+ set to 0 by default. The size of this list depends on ARIZONA_MAX_INPUT values.
+ ARIZONA_MAX_INPUT is defined in include/linux/mfd/arizona/pdata.h. If present,
+ exactly ARIZONA_MAX_INPUT values must be specified.
+
- DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
they are being externally supplied. As covered in
Documentation/devicetree/bindings/regulator/regulator.txt
--
2.0.0.390.gcb682f8
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [alsa-devel] [PATCH 2/2] mfd: arizona: Update DT binding to support INn_MODE
2014-08-09 8:35 [alsa-devel] [PATCH 2/2] mfd: arizona: Update DT binding to support INn_MODE Inha Song
@ 2014-08-11 10:06 ` Mark Rutland
0 siblings, 0 replies; 2+ messages in thread
From: Mark Rutland @ 2014-08-11 10:06 UTC (permalink / raw)
To: Inha Song
Cc: broonie, alsa-devel, patches, linux-kernel, lee.jones, ckeepax,
lgirdwood, sameo, devicetree, galak, ijc+devicetree, Pawel Moll,
robh+dt, cw00.choi
On Sat, Aug 09, 2014 at 09:35:45AM +0100, Inha Song wrote:
> This patch update DT binding to support INn_MODE init_data
>
> Signed-off-by: Inha Song <ideal.song@samsung.com>
> ---
> Documentation/devicetree/bindings/mfd/arizona.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index 5c7e723..c21a30e 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -42,6 +42,11 @@ Optional properties:
> the chip default will be used. If present exactly five values must
> be specified.
>
> + - wlf,inmode : A list of INn_MODE register values. If absent, INn_MODE register
> + set to 0 by default. The size of this list depends on ARIZONA_MAX_INPUT values.
> + ARIZONA_MAX_INPUT is defined in include/linux/mfd/arizona/pdata.h. If present,
> + exactly ARIZONA_MAX_INPUT values must be specified.
Please don't refer to Linux internals here. How many INn_MODE registers
can this hardware have?
Why does this need to be overriden? Please mention this in the commit
message and documentation.
Why is exposing a raw register value the best way of doing this?
Thanks,
Mark.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-11 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-09 8:35 [alsa-devel] [PATCH 2/2] mfd: arizona: Update DT binding to support INn_MODE Inha Song
2014-08-11 10:06 ` Mark Rutland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®